[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

This revision was automatically updated to reflect the committed changes. Closed by commit rG64b8a633a872: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex (authored by cebowleratibm, committed by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D88105?vs=293917=294222#toc

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

hubert.reinterpretcast added a comment. Off-list discussion seems to indicate that only the NFC portion of the patch was intended to be approved. That is, the scope of this patch is supposed to be https://reviews.llvm.org/D88105?id=293625 plus formatting changes. CHANGES SINCE LAST ACTION

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

hubert.reinterpretcast added a comment. Looks to me that this (since it is approved) completely replaces D88130 . The patch description needs to be changed of course. Not sure if the committer wants to try splitting out the non-AIX test as an NFC patch.

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added a comment. In D88105#2292266 , @nemanjai wrote: > This clearly changes behaviour and should thereby not have the `[NFC]` tag. Looks like it accidentally includes https://reviews.llvm.org/D88130. CHANGES SINCE LAST ACTION

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

nemanjai added a comment. This clearly changes behaviour and should thereby not have the `[NFC]` tag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA accepted this revision. ZarkoCA added a comment. Thanks for doing the formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm updated this revision to Diff 293917. cebowleratibm marked 2 inline comments as done. cebowleratibm added a comment. Reworked the prefixes and indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 Files:

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/powerpc-c99complex.c:7 + return x; +// PPC64LNX-LABEL: define { float, float } @foo1(float %x.{{.*}}, float %x.{{.*}}) #0 { +// PPC64LNX: ret { float, float } Nit: I don't think

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm updated this revision to Diff 293625. cebowleratibm marked an inline comment as done. cebowleratibm added a comment. Added ppc64le target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 Files:

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/powerpc-c99complex.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-linux -emit-llvm %s -o - | FileCheck %s --check-prefixes=PPC64LNX +// RUN: %clang_cc1 -triple powerpc-unknown-linux -emit-llvm %s -o - | FileCheck

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

cebowleratibm created this revision. cebowleratibm added reviewers: daltenty, ZarkoCA, sfertile. Herald added subscribers: cfe-commits, shchenz, nemanjai. Herald added a project: clang. cebowleratibm requested review of this revision. Adding this test so that I can extend it in a follow on patch