[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG766ee1096f0b: [Clang][RISCV] Define RISC-V V builtin types (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. In D92715#2544233 , @craig.topper wrote: > In D92715#2544178 , @HsiangKai wrote: > >> In D92715#2520925 , @craig.topper >> wrote: >> >>> I

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. In D92715#2544178 , @HsiangKai wrote: > In D92715#2520925 , @craig.topper > wrote: > >> I wonder if these types should be prefixed with "__clang_" like AArch64 >> tuple types? > > It

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. Herald added subscribers: StephenFan, vkmr. In D92715#2520925 , @craig.topper wrote: > I wonder if these types should be prefixed with "__clang_" like AArch64 tuple > types? It seems only AArch64 tuple types have "__clang_"

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 319144. HsiangKai added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. I wonder if these types should be prefixed with "__clang_" like AArch64 tuple types? Comment at: clang/lib/AST/ASTContext.cpp:3875 +IsFP) \ + if (!EltTy->isBooleanType()

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. Ping. If we all agree to use builtin types to model RVV types, is there any other issues we need to address in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316854. HsiangKai added a comment. According to "9. Vector Memory Alignment Constraints" in V specification, change the alignment of RVV types to the element size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316556. HsiangKai added a comment. Recover comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316553. HsiangKai added a comment. Refine debug info for RVV types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added a comment. In D92715#2495897 , @HsiangKai wrote: > @liaolucy RISC-V vector types are sizeless types. Sizeless is kind of > characteristic for builtin types. If we use attribute to declare RISC-V > vector types, the frontend does not know

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. @liaolucy RISC-V vector types are sizeless types. Sizeless is kind of characteristic for builtin types. If we use attribute to declare RISC-V vector types, the frontend does not know anything about it. I still think to define RISC-V vector types as builtin types is a

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

erichkeane added a comment. In D92715#2446479 , @craig.topper wrote: > I think it would be possible to add a new attribute to define these types. > But only specific values for parameters would be allowed so that it could > only generate the exact

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. @rsmith or @rjmccall do you have any opinions on whether we should use builtin types like SVE or create a new attribute for RISCV? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. I think it would be possible to add a new attribute to define these types. But only specific values for parameters would be allowed so that it could only generate the exact types we see here and the future segment load patches. It wouldn't be general purpose like

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

asb added a comment. In D92715#2443376 , @craig.topper wrote: > Can we discuss this patch in tomorrows RISC-V meeting? @jrtc27 @kito-cheng > @khchen @liaolucy I've added it to the agenda CHANGES SINCE LAST ACTION

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. Can we discuss this patch in tomorrows RISC-V meeting? @jrtc27 @kito-cheng @khchen @liaolucy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:68 +RVV_VECTOR_TYPE_INT("__rvv_int8mf2_t", RvvInt8mf2, RvvInt8mf2Ty, 4, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m1_t", RvvInt8m1, RvvInt8m1Ty, 8, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

kito-cheng added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

khchen added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro updated this revision to Diff 310044. evandro marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro marked 7 inline comments as done. evandro added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:32 +// - ElBits is the size of one element in bits (SEW). +// +// - IsSigned is true for vectors of signed integer elements and

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true)

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:32 +// - ElBits is the size of one element in bits (SEW). +// +// - IsSigned is true for vectors of signed integer elements and craig.topper wrote: > NF argument isn't

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:32 +// - ElBits is the size of one element in bits (SEW). +// +// - IsSigned is true for vectors of signed integer elements and NF argument isn't documented. And is always

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro updated this revision to Diff 309750. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro updated this revision to Diff 309749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. Can you re-upload the patch with full context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing list

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro created this revision. evandro added reviewers: Hsiang-Kai, craig.topper, rogfer01, frasercrmck. Herald added subscribers: dexonsmith, NickHung, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck,