[PATCH] D99839: [C++, test] Fix typo in NSS* vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv()

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre updated this revision to Diff 338811. thopre marked an inline comment as done. thopre added a comment. Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +//

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre created this revision. thopre added reviewers: respindola, pcc, EricWF. thopre requested review of this revision. Herald added a project: clang. The NSS FileCheck variables at the end of the CodeGenCXX/split-stacks.cpp clang testcase are off by 1, resulting in the use of an undefined