This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE330492: [clang-tidy] add new check to find out objc ivars
which do not have prefix _ (authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45392?vs=142057=143408#toc
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Wizard added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming-objc.m:4
+// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \
+// RUN: --
+
alexfh wrote:
> The `--` and the trailing backslash above can be
alexfh added a comment.
BTW, it looks like the
http://clang.llvm.org/extra/clang-tidy/checks/objc-property-declaration.html
check could also be replaced with readability-identifier-naming (not in this
patch).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
alexfh added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9
+// RUN: ]}' -- -fno-delayed-template-parsing \
+// RUN: -I%S/Inputs/readability-identifier-naming \
+// RUN: -isystem %S/Inputs/readability-identifier-naming/system
+
Wizard added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9
+// RUN: ]}' -- -fno-delayed-template-parsing \
+// RUN: -I%S/Inputs/readability-identifier-naming \
+// RUN: -isystem %S/Inputs/readability-identifier-naming/system
+
Wizard updated this revision to Diff 142057.
Wizard added a comment.
remove unnecessary flags
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming-objc.m
Index:
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you, that's much better!
I'd also appreciate, if you could document the options this check supports in
its .rst document (separately from this patch).
A few more comments
Eugene.Zelenko added a comment.
How about doing same for //objc-property-declaration//?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Wizard added a comment.
In https://reviews.llvm.org/D45392#1063164, @alexfh wrote:
> In https://reviews.llvm.org/D45392#1061960, @Wizard wrote:
>
> > In https://reviews.llvm.org/D45392#1061433, @alexfh wrote:
> >
> > > I wonder whether the readability-identifier-naming check could be
> > >
Wizard updated this revision to Diff 141938.
Wizard added a comment.
move check to readability-identifier-naming
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
alexfh added a comment.
In https://reviews.llvm.org/D45392#1061960, @Wizard wrote:
> In https://reviews.llvm.org/D45392#1061433, @alexfh wrote:
>
> > I wonder whether the readability-identifier-naming check could be extended
> > to support this use case instead of adding a new check
Wizard added a comment.
In https://reviews.llvm.org/D45392#1061433, @alexfh wrote:
> I wonder whether the readability-identifier-naming check could be extended to
> support this use case instead of adding a new check specifically for
> underscores in ivar names?
Hmm
alexfh added a comment.
I wonder whether the readability-identifier-naming check could be extended to
support this use case instead of adding a new check specifically for
underscores in ivar names?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Wizard updated this revision to Diff 141574.
Wizard added a comment.
reorder release note for alphabetical order
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/IvarDeclarationCheck.cpp
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D45392#1061064, @Wizard wrote:
> In https://reviews.llvm.org/D45392#1060971, @Eugene.Zelenko wrote:
>
> > In https://reviews.llvm.org/D45392#1060912, @Wizard wrote:
> >
> > > In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko
Wizard added a comment.
In https://reviews.llvm.org/D45392#1060971, @Eugene.Zelenko wrote:
> In https://reviews.llvm.org/D45392#1060912, @Wizard wrote:
>
> > In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote:
> >
> > > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote:
>
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D45392#1060912, @Wizard wrote:
> In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote:
>
> > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote:
> >
> > > In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko
Wizard added a comment.
In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote:
> In https://reviews.llvm.org/D45392#1060845, @Wizard wrote:
>
> > In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote:
> >
> > > If this is Apple guideline, check name should reflect this. I
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D45392#1060845, @Wizard wrote:
> In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote:
>
> > If this is Apple guideline, check name should reflect this. I think will be
> > good idea to have general check for Apple naming
Wizard updated this revision to Diff 141515.
Wizard edited the summary of this revision.
Wizard added a comment.
resolve comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/IvarDeclarationCheck.cpp
Wizard marked 4 inline comments as done.
Wizard added a comment.
In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote:
> If this is Apple guideline, check name should reflect this. I think will be
> good idea to have general check for Apple naming conventions instead of
> separate
Eugene.Zelenko added a comment.
If this is Apple guideline, check name should reflect this. I think will be
good idea to have general check for Apple naming conventions instead of
separate checks for specific situations like //objc-ivar-declaration// and
//objc-property-declaration//.
23 matches
Mail list logo