[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount updated this revision to Diff 351308. isthismyaccount added a comment. Rebased to hopefully resolve merge issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount commandeered this revision. isthismyaccount edited reviewers, added: aabbaabb; removed: isthismyaccount. isthismyaccount added a comment. Grabbing this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount added a comment. Thanks for the reviews. I'll take over this and try to get the merge conflicts resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing

[PATCH] D101139: Create install targets for scan-build-py.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing list

[PATCH] D101139: Create install targets for scan-build-py.

wanders added a comment. I think this looks good. I can't vouch for the cmake changes. However there seems like diff is based on something that already has moved parts into libexec. It doesn't apply cleanly here - and buildkite seems to complain too. Make sure you have the complete diff.

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 345329. aabbaabb added a comment. put libs in 'lib' folder, 'analyze-*' and 'scan-*' compiler wrappers to 'libexec', also copy the resources in 'libscanbuild' Tests: To install: DESTDIR=${INSTALL_DIR} ninja install-scan-build-py -j1000 Test at source

[PATCH] D101139: Create install targets for scan-build-py.

wanders added a comment. In D101139#2743346 , @aabbaabb wrote: > Renamed lib to libexec and add custom rules to copy files to build output. That rename was a bit too fast I think. I would expect the libraries (libear & libscanbuild) to be in lib/. The

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 344904. aabbaabb marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt

[PATCH] D101139: Create install targets for scan-build-py.

phosek added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:1-7 +set (BinFiles + "analyze-build" + "analyze-c++" + "analyze-cc" + "intercept-build" + "intercept-c++" + "intercept-cc") Shouldn't this list also

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 343541. aabbaabb marked 3 inline comments as done. aabbaabb added a comment. Renamed lib to libexec and add custom rules to copy files to build output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. Looking at `libear/__init__.py`, it's basically replicating CMake build to the point where it even emulates CMake template expansion, see https://github.com/llvm/llvm-project/blob/a3a8a1a15b524d91b5308db68e9d293b34cd88dd/clang/tools/scan-build-py/libear/__init__.py#L204.

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb marked an inline comment as done. aabbaabb added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + wanders wrote: > This overwrites the "bin/scan-build" that was installed from the

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 342529. aabbaabb added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Rename scan-build to scan-build-py during install to prevent overwriting pearl implementation. CHANGES SINCE LAST ACTION

[PATCH] D101139: Create install targets for scan-build-py.

wanders added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + This overwrites the "bin/scan-build" that was installed from the scan-build (no -py) subdirectory. So with this

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2721880 , @phosek wrote: > In D101139#2718112 , @aabbaabb > wrote: > >> In D101139#2718057 , @phosek wrote: >> >>> In

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 341352. aabbaabb edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. In D101139#2718112 , @aabbaabb wrote: > In D101139#2718057 , @phosek wrote: > >> In D101139#2713530 , @aabbaabb >> wrote: >> >>> The python

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2718057 , @phosek wrote: > In D101139#2713530 , @aabbaabb > wrote: > >> The python script assumes relative directory while finding things. For >> example, for resources

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. In D101139#2713530 , @aabbaabb wrote: > The python script assumes relative directory while finding things. For > example, for resources folder, it uses os.path.join(this_dir, 'resources') in > report.py, which means resource

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2713450 , @phosek wrote: > I don't think this is sufficient. First, we want to be explicit and always > list individual files to install, we don't use patterns. Second, since > libscanbuild is a library, it

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. The python script assumes relative directory while finding things. For example, for resources folder, it uses os.path.join(this_dir, 'resources') in report.py, which means resource need to be in the same dir as report.py. Similarly for the libscanbuild. it assumes the

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. I don't think this is sufficient. First, we want to be explicit and always list individual files to install, we don't use patterns. Second, since libscanbuild is a library, it shouldn't be installed inside the `bin` directory. I think those should go either into `lib`