[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

2022-05-02 Thread Min-Yih Hsu via Phabricator via cfe-commits
myhsu added a comment. Just curious: Have you considered using llvm::opt or even llvm::cl infrastructure? What are the pros & cons? Comment at: clang/utils/TableGen/ClangSAConfigsEmitter.cpp:24 + +using SortedRecords = llvm::StringMap; +

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

2022-03-24 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added reviewers: jansvoboda11, myhsu. steakhal added subscribers: jansvoboda11, myhsu. steakhal added a comment. Herald added a project: All. > We can put all the acceptable values in the help text AND generate the enum > class WITHOUT any redundancy. +1 > While not demonstrated, it'd

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

2021-06-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D104439#2832984 , @Szelethus wrote: > Ping. > > The main question with this patch really is whether we want TableGen at all > or not, as for what we generate precisely and how we'd utilize it is a > discussion for later.

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

2021-06-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Ping. The main question with this patch really is whether we want TableGen at all or not, as for what we generate precisely and how we'd utilize it is a discussion for later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

2021-06-17 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, martong, balazske, steakhal, xazax.hun. Szelethus added a project: clang. Herald added subscribers: manas, dang, ASDenysPetrov, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,