[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. It seems we need not adding this test, since a similiar test is added in https://reviews.llvm.org/rGb31199bab4865deef4e778d7a028c8ec64285654 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

MaskRay added a comment. In D107684#2936034 , @mhjacobson wrote: > In D107684#2936033 , @MaskRay wrote: > >> `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. >> >> sysroot is usually a directory

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2936033 , @MaskRay wrote: > `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. > > sysroot is usually a directory which contains `usr/lib` and `lib/`. > `somewhere/usr/lib` is not usually used as a

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

MaskRay added a comment. `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. sysroot is usually a directory which contains `usr/lib` and `lib/`. `somewhere/usr/lib` is not usually used as a sysroot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson updated this revision to Diff 365343. mhjacobson added a comment. Rebase atop recent changes; use separate check lines and string substitution for `SYSROOT`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:17 +// RUN: %clang %s -### -no-canonical-prefixes -target avr --sysroot %S/Inputs/basic_avr_tree/usr/lib 2>&1 | FileCheck -check-prefix CC1D %s +// CC1D: clang{{.*}} "-cc1" "-triple" "avr" {{.*}}

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

MaskRay added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:17 +// RUN: %clang %s -### -no-canonical-prefixes -target avr --sysroot %S/Inputs/basic_avr_tree/usr/lib 2>&1 | FileCheck -check-prefix CC1D %s +// CC1D: clang{{.*}} "-cc1" "-triple" "avr" {{.*}}

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. @MaskRay I think this test is OK. What is your opinion ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.org/D107684 ___ cfe-commits mailing

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2932609 , @benshi001 wrote: > In D107684#2932605 , @mhjacobson > wrote: > >> In D107684#2932603 , @benshi001 >> wrote: >> >>> We

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson updated this revision to Diff 364942. mhjacobson added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.org/D107684 Files: clang/test/Driver/avr-toolchain.c Index:

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. In D107684#2932605 , @mhjacobson wrote: > In D107684#2932603 , @benshi001 > wrote: > >> We need not add another `basic_avr_tree_opt_local`, since you added `/avr` >> to possible

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2932603 , @benshi001 wrote: > We need not add another `basic_avr_tree_opt_local`, since you added `/avr` to > possible avr-libc pathes, you can test your change by specifying `--sysroot >

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. We need not add another `basic_avr_tree_opt_local`, since you added `/avr` to possible avr-libc pathes, you can test your change by specifying `--sysroot %S/Inputs/basic_avr_tree/usr/lib/` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:9 -// RUN: %clang %s -### -target avr --sysroot %S/Inputs/basic_avr_tree 2>&1 -nostdinc | FileCheck -check-prefix CC1B %s -// CC1B-NOT: "-internal-isystem" {{".*avr/include"}} +// RUN: %clang %s

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson created this revision. mhjacobson added reviewers: MaskRay, benshi001. Herald added subscribers: Jim, dylanmckay. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test that ensures that an avr-libc in