Re: [PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

Hey Kirill, If you mean removing traversal of the enumdecl->enumtype in RecursiveASTVisitor, that's a subtle change that potentially affects a lot of callers. We'd need to be able to revert it, so we shouldn't rely on it to get the tests back to green. It looks like there's a single assertion

Re: [PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

Yes, I'm aware and actively working on this one. I think I have the fix but I'm trying to run all the tests (Clang etc) to make sure it doesn't break anything else. On Tue, Oct 26, 2021 at 5:01 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > >

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

thakis added a comment. Follow-up commit https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897 (which doesn't seem to have its own phab link) broke clangd tests everywhere, e.g. http://45.33.8.238/linux/59134/step_9.txt Please take a look. This is like the

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG593814a10cb4: [clangd] IncludeCleaner: Complicated rules for enum usage (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 382065. kbobyrev added a comment. Delete duplicate tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified.

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 382063. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review & offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified.

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified.

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 381992. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:38 bool VisitTagType(TagType *TT) { +// For enumerations we will require only the definition if it's present and +// the underlying type is not specified. I don't

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 381198. kbobyrev added a comment. Add one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev updated this revision to Diff 381195. kbobyrev added a comment. Remove unwanted (though good) formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112209/new/ https://reviews.llvm.org/D112209 Files:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG