[PATCH] D112353: [bazel] fixes for windows build

ychen added a comment. In D112353#3291381 , @GMNGeoffrey wrote: > If you'd like to rebase this and see what's still outstanding, I can take > another look :-) Thanks for getting around to this. I rebased the patch and reran the build. It seems the

[PATCH] D112353: [bazel] fixes for windows build

GMNGeoffrey added a comment. If you'd like to rebase this and see what's still outstanding, I can take another look :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112353/new/ https://reviews.llvm.org/D112353

[PATCH] D112353: [bazel] fixes for windows build

ychen added inline comments. Comment at: utils/bazel/llvm-project-overlay/llvm/config.bzl:63 # MSVC specific -"stricmp=_stricmp", -"strdup=_strdup", +#"stricmp=_stricmp", +#"strdup=_strdup", GMNGeoffrey wrote: > Just commenting these out

[PATCH] D112353: [bazel] fixes for windows build

GMNGeoffrey added a subscriber: chandlerc. GMNGeoffrey added a comment. Thanks for upstreaming your fixes :-) It looks like this has some overlap with https://reviews.llvm.org/D112399 and https://reviews.llvm.org/D111930. Let's let those land and then see what's still necessary here

[PATCH] D112353: [bazel] fixes for windows build

ychen created this revision. ychen added a reviewer: GMNGeoffrey. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Giving Bazel a try on Win10 by following the README. It needs these fixes to build through. Think that I should sent it