[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e6e022d21f: Re-land [Clang][ScanDeps] Use the virtual path for module maps (authored by Bigcheese, committed by lenary). Changed prior to commit: https://reviews.llvm.org/D114206?vs=394303=397972#toc

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. @Bigcheese I am sorry - after a lot of further investigation, it was due to an odd interaction with some downstream changes. I will re-land your changes, with correct attribution to you.

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added a comment. In D114206#3221950 , @Bigcheese wrote: > In D114206#3221893 , @lenary wrote: > >> Update: I'm going to revert this on main. This patch was accepted >> conditionally on you fixing the

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese added a comment. In D114206#3221893 , @lenary wrote: > Update: I'm going to revert this on main. This patch was accepted > conditionally on you fixing the windows crash, which you have not done, so > this was landed without being accepted. >

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary reopened this revision. lenary added a comment. This revision is now accepted and ready to land. Update: I'm going to revert this on main. This patch was accepted conditionally on you fixing the windows crash, which you have not done, so this was landed without being accepted. Revert is

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added a comment. @Bigcheese have you got a fix for the vfs issue with `.` and `..`? Looking closely at your comment, I'm surprised you landed this without an llvm-lit xfail for windows, given your comment above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added inline comments. Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml +// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format

Re: [PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

On Tue, Dec 14, 2021 at 6:17 PM Richard Smith - zygoloid via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith added inline comments. > > > > Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 > +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > >

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

rsmith added inline comments. Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml +// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04192422c4e3: [Clang][ScanDeps] Use the virtual path for module maps (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese updated this revision to Diff 391166. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114206/new/ https://reviews.llvm.org/D114206 Files: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese added a comment. There were two issues for Windows. The first is an actual bug in the Clang VFS that should be fixed separately. You cannot pass just `main.m` as the input to Clang. Clang asks for its parent directory textually, which is `.`. It then tries to stat `.`, which the VFS

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM provided the Windows crash gets resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114206/new/

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

Bigcheese created this revision. Bigcheese added reviewers: jansvoboda11, dexonsmith. Bigcheese added a project: clang. Bigcheese requested review of this revision. Herald added a subscriber: cfe-commits. This patch makes clang-scan-deps use the virtual path for module maps instead of the on