Re: [Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Rachel Lane 07459167844 > On 29 Jan 2022, at 10:57, Simon Pilgrim via Phabricator via lldb-commits > wrote: > > This revision was landed with ongoing or failed builds. > This revision was automatically updated to reflect the committed changes. > Closed by commit rG058c5dfc78cd: Raise the

Re: [Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Hi I just wanted to say Thanks Rachel Lane 07459167844 > On 29 Jan 2022, at 10:57, Simon Pilgrim via Phabricator via lldb-commits > wrote: > > This revision was landed with ongoing or failed builds. > This revision was automatically updated to reflect the committed changes. > Closed by

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. mlir-windows buildbot looks to be green now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___ cfe-commits mailing list

Re: [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

ro.org ; mlek...@skidmore.edu ; blitzrak...@gmail.com ; shen...@google.com ; michael.hl...@gmail.com ; bruce.mitche...@gmail.com ; yuanfang.c...@sony.com Subject: [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019 RKSimon added a comment. @stella.stamenova It look

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @stella.stamenova It looks like the mlir-windows buildbot is still using VS2017: CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message): Host Visual Studio version must be at least 19.20, your version is 19.16.27045.0. Are you able to make the

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG058c5dfc78cd: Raise the minimum Visual Studio version to VS2019 (authored by RKSimon). Changed prior to commit:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403924. RKSimon added a comment. update lldb cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. Herald added a subscriber: JDevlieghere. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403574. RKSimon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb docs as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of this change to also point to >>

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3273761 , @stella.stamenova wrote: > Can we update the lldb instructions as part of this change to also point to > VS2019? Alternatively, I can send a separate change for that. I'll add it to this patch - are people

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. Can we update the lldb instructions as part of this change to also point to VS2019? Alternatively, I can send a separate change for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. >> https://lab.llvm.org/buildbot/#/builders/sanitizer-windows >> https://lab.llvm.org/buildbot/#/builders/clang-x64-windows-msvc Actually these were already on VS2019, version 16.8, so I only updated them both to 16.11. Repository: rG LLVM Github Monorepo

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. In D114639#3228704 , @rnk wrote: > In D114639#3199458 , @RKSimon wrote: > >> @rnk I'm not certain but I think the only buildbot still using VS2017 is >> windows-gcebot2 ? > > Yes, it

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

rnk added a comment. In D114639#3199458 , @RKSimon wrote: > @rnk I'm not certain but I think the only buildbot still using VS2017 is > windows-gcebot2 ? Yes, it probably uses VS2017, and probably also the sanitizer-windows bot as well:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @rnk I'm not certain but I think the only buildbot still using VS2017 is windows-gcebot2 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3192823 , @stella.stamenova wrote: > In D114639#3191752 , @RKSimon wrote: > >> @rnk @stella.stamenova How long do you think it will be before you can >> update your

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3191752 , @RKSimon wrote: > @rnk @stella.stamenova How long do you think it will be before you can update > your buildbots to VS2019 or VS2022 please? The mlir buildbot was updated already. The lldb buildbot

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @rnk @stella.stamenova How long do you think it will be before you can update your buildbots to VS2019 or VS2022 please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3183244 , @Meinersbur wrote: > ping? > > @erichkeane Since you are pushing for upgrade the gcc/clang requirement as > well, would you take care of that? I was looking into the patch to do so, but I don't have a

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. > I still don't see a need for them to be updated in lock step, especially for > Visual Studio which tends to be quite different from other toolchains, but I > can see the use of the bumps occurring within the same release version of > llvm if its feasible. It's

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Meinersbur added a comment. ping? @erichkeane Since you are pushing for upgrade the gcc/clang requirement as well, would you take care of that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162157 , @mehdi_amini wrote: > In D114639#3162141 , @erichkeane > wrote: > >>> Right, but last time we did the motivation was specifically to get to >>> c++14, while here

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390824. RKSimon edited the summary of this revision. RKSimon added a comment. Changed cmake example back to VS2019 Added note for minimum cmake version necessary for VS2022 Updated the soft version limit to: _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3162157 , @mehdi_amini wrote: > In D114639#3162141 , @erichkeane > wrote: > >>> Right, but last time we did the motivation was specifically to get to >>> c++14, while

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3162141 , @erichkeane wrote: >> Right, but last time we did the motivation was specifically to get to c++14, >> while here the motivation is to drop an old MSVC according to the >> MSVC-specific support we

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3162133 , @mehdi_amini wrote: > In D114639#3162069 , @erichkeane > wrote: > >> In D114639#3162032 , @RKSimon >> wrote: >> >>> In

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3162069 , @erichkeane wrote: > In D114639#3162032 , @RKSimon wrote: > >> In D114639#3162000 , @mehdi_amini >> wrote: >> >>> In

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a subscriber: jfb. erichkeane added a comment. In D114639#3162032 , @RKSimon wrote: > In D114639#3162000 , @mehdi_amini > wrote: > >> In D114639#3161303

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3162000 , @mehdi_amini wrote: > In D114639#3161303 , @erichkeane > wrote: > >> IMO, if we're updating the MSVC versions, we should do the same for the >>

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3161303 , @erichkeane wrote: > IMO, if we're updating the MSVC versions, we should do the same for the > GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and > Clang 3.5 is from 2014.

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. See: https://lists.llvm.org/pipermail/llvm-dev/2021-November/153882.html for what I was thinking of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. In D114639#3161440 , @erichkeane wrote: > In D114639#3161362 , @aaron.ballman > wrote: > >> In D114639#3161303 , @erichkeane >> wrote:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3161362 , @aaron.ballman wrote: > In D114639#3161303 , @erichkeane > wrote: > >> IMO, if we're updating the MSVC versions, we should do the same for the >>

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. In D114639#3161303 , @erichkeane wrote: > IMO, if we're updating the MSVC versions, we should do the same for the > GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and > Clang 3.5 is from 2014.

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. IMO, if we're updating the MSVC versions, we should do the same for the GCC/Clang/AppleClang versions too. For example, GCC 5.1 is from 2015, and Clang 3.5 is from 2014. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. Thanks - I think all the MSVC bot admins are now on this patch, so I can avoid writing yet another email! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added a comment. Re. the bots: I'd hope we'd have at least some bots using VS2019 rather than all rushing to VS2022. There's nothing worse than claiming to support a minimum version of something and then not actually supporting it...! Also internally, we are switching to a default

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3160031 , @mehdi_amini wrote: > In D114639#3158401 , @RKSimon wrote: > >>> Have you checked whether there are any bots in the lab that will need to be >>> updated?

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

mehdi_amini added a comment. In D114639#3158401 , @RKSimon wrote: >> Have you checked whether there are any bots in the lab that will need to be >> updated? > > I did find a number of bots that I think need addressing, I am intending to > privately

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. Meinersbur wrote: > jhenderson wrote: > > RKSimon wrote: > > > aaron.ballman wrote: >

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Meinersbur added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. jhenderson wrote: > RKSimon wrote: > > aaron.ballman wrote: > > > jhenderson wrote:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. In D114639#3158401 , @RKSimon wrote: >> Have you checked whether there are any bots in the lab that will need to be >> updated? > > I did find a number of bots that I think need addressing, I am intending to > privately

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. RKSimon wrote: > aaron.ballman wrote: > > jhenderson wrote: > > > I think the

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. > Have you checked whether there are any bots in the lab that will need to be > updated? I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. Have you checked whether there are any bots in the lab that will need to be updated? Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM ..

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390283. RKSimon added a comment. rebase and add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added a comment. No more comments from me (apart from one minor nit). This should definitely get someone with more familiarity with how these things are configured to take a look though. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390082. RKSimon added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 16 2019" -T LLVM .. Maybe make this VS2022 instead, to help it last longer? Comment

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon created this revision. RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson, Meinersbur, jansvoboda11, gbedwell. Herald added subscribers: dexonsmith, mstorsjo, mgorny. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: