This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG55b702c37b7e: [clangd] NFC, emit source ranges in selection
debug messages. (authored by hokein).
Changed prior to commit:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/clangd/Selection.cpp:551
printNodeKind(OS, N);
OS << " ";
return std::move(OS.str());
hmm, while here,
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:704
+ dlog("{1}skip: {0}", printNodeToString(N, PrintPolicy, SM), indent());
dlog("{1}skipped range = {0}", S.printToString(SM), indent(1));
return true;
hokein updated this revision to Diff 401219.
hokein added a comment.
address commment, only printing range on push.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117475/new/
https://reviews.llvm.org/D117475
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:473
printNodeKind(OS, N);
- OS << " ";
+ OS << " " << N.getSourceRange().printToString(SM) << " ";
return std::move(OS.str());
I don't think this belongs in
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
It will make the output more versbose,
