[PATCH] D117973: [cmake] Support custom package install paths

sebastian-ne added a comment. I found a regression when llvm is added with CMake’s add_subdirectory. D130555 has a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973

[PATCH] D117973: [cmake] Support custom package install paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Ericson2314 marked 2 inline comments as done. Closed by commit rGac0d1d5c7b7e: [cmake] Support custom package install paths (authored by Ericson2314). Repository:

[PATCH] D117973: [cmake] Support custom package install paths

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. Thank you, the comments make it clearer what’s happening. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: cmake/Modules/FindPrefixFromConfig.cmake:30 + if(IS_ABSOLUTE "${path_to_leave}") +set(prefix_var + "# Installation prefix is fixed absolute path" sebastian-ne

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 447361. Ericson2314 added a comment. Fix bug, and add comments to both branches for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 Files:

[PATCH] D117973: [cmake] Support custom package install paths

sebastian-ne added a comment. Two comments inline, apart from that it looks good to me. Comment at: cmake/Modules/FindPrefixFromConfig.cmake:30 + if(IS_ABSOLUTE "${path_to_leave}") +set(prefix_var + "# Installation prefix is fixed absolute path"

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a subscriber: nikic. Ericson2314 added a comment. @nikic if you are still around, might you want to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 446609. Ericson2314 added a comment. - Rebase - Some `set` -> `extend_path` - Fix spelling / comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 Files:

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a comment. https://reviews.llvm.org/D130254 oh yay I learned from this the openmp failure is in fact spurious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 435049. Ericson2314 added a comment. Herald added a subscriber: bzcheeseman. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a comment. Could one of you review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 ___ cfe-commits mailing list

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 created this revision. Ericson2314 added reviewers: compnerd, phosek, beanz, sterni. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox,