[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3824657 , @MaskRay wrote: > mips computed sysroot from GCCInstallation very early in 2013 > rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 > and >

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

MaskRay added a comment. mips computed sysroot from GCCInstallation very early in 2013 rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 and Android followed up in 2018 (D45291 ), but I am not sure

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3431569 , @dyung wrote: > Hi, one of the tests you added. csky-toolchain.c seems to be failing on a > Windows build bot, and from a quick look, it appears to be a path separator > issue. Can you take a look? > >

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

dyung added a comment. Hi, one of the tests you added. csky-toolchain.c seems to be failing on a Windows build bot, and from a quick look, it appears to be a path separator issue. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/2452 Repository: rG LLVM Github

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97e496054a37: [Clang][CSKY] Add the CSKY target and compiler driver (authored by zixuan-wu). Changed prior to commit:

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. In D121445#3418195 , @zixuan-wu wrote: > I have met this before because the downloading of patch will ignore empty > files. You can have a check

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3416518 , @rengolin wrote: > There is also a test error: > > TEST 'Clang :: Driver/csky-toolchain.c' FAILED > > ... >

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added a comment. I just applied this to a recent HEAD and got a few warnings. Please make sure there are no new warnings on changes / new files. /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/CSKYInstrFormats.td:658:62: warning: unused template argument: R_Z_2:pattern

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu updated this revision to Diff 419076. zixuan-wu added a comment. Herald added subscribers: StephenFan, dexonsmith, MaskRay. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 Files: clang/lib/Basic/CMakeLists.txt

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3388842 , @rengolin wrote: > I'm surprised these tests are passing for you. Perhaps you're not building or > running them all. > > To make sure you're running your tests, you need to build both clang and llvm >

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

DavidSpickett added a comment. > You can also run lit directly on each test, but I can't remember how to do > that now... If you're in the build dir: ./bin/llvm-lit ../llvm-project/clang/test/.. -a (-a gives you full output of what happens) Some tests are a bit odd when you do this but

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added a comment. I'm surprised these tests are passing for you. Perhaps you're not building or running them all. To make sure you're running your tests, you need to build both clang and llvm (`-DLLVM_ENABLE_PROJECTS=clang`) and run ninja/make `check-all`. You can also run `lit`

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added inline comments. Comment at: clang/test/Driver/csky-arch-error.c:1 +// RUN: %clang -target csky-unknown-elf -march=csky -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s This will error out and fail the test. You need to add

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. I have updated the patch. Any more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu updated this revision to Diff 415006. zixuan-wu added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 Files:

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added inline comments. Comment at: clang/test/Driver/csky-arch.c:26 + +// RUN: %clang -target csky-unknown-elf -march=csky -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s rengolin wrote: > I don't think this is doing what you

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added inline comments. Comment at: clang/lib/Basic/Targets/CSKY.cpp:43 + Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1"); + Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1"); + DavidSpickett wrote: > Any need to handle

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/CSKY.cpp:43 + Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1"); + Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1"); + Any need to handle when ABI is not avbiv2

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added a comment. I don't know enough about your toolchain requirements, but this looks good to me. Please check the clang-format warnings. If you did pass clang-format, perhaps you need to upgrade to a newer one? I won't approve just yet, to let other people review it also.

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, kito.cheng, rsmith, asb, DavidSpickett, kaz7. Herald added subscribers: krytarowski, mgorny. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: