[PATCH] D122008: [flang][driver] Add support for generating executables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97a32d3e43fe: [flang][driver] Add support for generating executables (authored by awarzynski). Changed prior to commit:

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. In D122008#3462665 , @klausler wrote: > New comments or not, this step remains premature from my perspective. Let me make `-flang-experimental-exec` a "hidden" option then. This way this flag (and the functionality that it

[PATCH] D122008: [flang][driver] Add support for generating executables

klausler added a comment. In D122008#3462550 , @awarzynski wrote: > Btw, if there are no new comments, I would like to merge this in the coming > days. New comments or not, this step remains premature from my perspective. Repository: rG LLVM

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. Btw, if there are no new comments, I would like to merge this in the coming days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. In D122008#3456445 , @clementval wrote: > Do you plan to discuss this again during the next call? Note that today is a > holiday in various country in Europe (maybe elsewhere too) so the one on 4/27 > is probably better.

[PATCH] D122008: [flang][driver] Add support for generating executables

clementval added a comment. Do you plan to discuss this again at during the next call? Note that today is a holiday in various country in Europe (maybe elsewhere too) so the one on 4/27 is probably better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422841. awarzynski added a comment. Update the tests after the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files:

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422836. awarzynski added a comment. Add a flang, `-flang-experimental-exec`, to guard the new functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. @h-vetinari & @rouson, thanks for the encouragement! In D122008#3450214 , @h-vetinari wrote: > I'd be more than a little surprised that there's no way to do this. Have you > tried CMAKE_Fortran_FLAGS >

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. @awarzynski I'll echo your comment that "... most people new to LLVM Flang use flang rather than flang-new and most (all?) find it very confusing." I've known of flang in various forms (including a flang predated classic flang) and yet I'm still finding new information

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. @awarzynski based on @h-vetinari's optimism about adding flags, I still like option 2. If it's not possible to add flags, then I would prefer option 1. If we go with option 3, then I am at least encouraged by reviewing the upstreaming project status links that @kiran

[PATCH] D122008: [flang][driver] Add support for generating executables

h-vetinari added a comment. Speaking as a relative outside (but who's been waiting for flang in LLVM since well before it joined the monorepo), I'd much prefer code-generation-with-rough-edges in LLVM 15 (to start testing and raising eventual bugs), rather than a more polished flang

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422525. awarzynski added a comment. Updates based on feedback from @MaskRay (thank you!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files:

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. Thank you all for your feedback! **CMake integration** I have a couple more data points. I've experimented with CMake using Tin's CMake PR . I confirm that together with this patch, I was able to build a

[PATCH] D122008: [flang][driver] Add support for generating executables

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:392 + //* on some platforms, we may need to use lib64 instead of lib (you can use + //CLANG_LIBDIR_SUFFIX to automate this) + //* this logic should also work on other similar platforms

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422143. awarzynski added a comment. Updates required after https://reviews.llvm.org/D122444 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files:

[PATCH] D122008: [flang][driver] Add support for generating executables

tschuett added a comment. In my example, they even promised that the flag will removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 ___ cfe-commits mailing

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. I also very much like the second option. I think it prevents a naive user from stumbling into treacherous territory. Also, as someone who is funded to write tests for flang, making it easier to build executables would expand the options for testing. Currently, we're

[PATCH] D122008: [flang][driver] Add support for generating executables

rovka added a comment. Just for the record, I'd like to speak in favor of option 2 - merge the patch now, but put the functionality behind a flag. This sounds like a good compromise to me. I think if we choose an inconspicuous name like -fexperimentail-test-driver-integration-with-cmake (or

[PATCH] D122008: [flang][driver] Add support for generating executables

richard.barton.arm added a comment. Option 1 for me, let's not delay. With upstreaming of fir-dev making great progress, we can start to think about having a working flang in LLVM 15. For that we would need to have upstreaming finished, the driver finished and CMake support finished before end

[PATCH] D122008: [flang][driver] Add support for generating executables

tschuett added a comment. https://reviews.llvm.org/D54604 used a really ugly flag: `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/

[PATCH] D122008: [flang][driver] Add support for generating executables

klausler added a comment. There's 128037 lines of code and documentation outside of lowering and drivers in flang/, and "git blame" tells me that I wrote 63% of them, including most of the Fortran semantics and nearly all of the Fortran parsing and runtime. Based on my knowledge of the code

[PATCH] D122008: [flang][driver] Add support for generating executables

sscalpone added a comment. As I said this morning, I prefer to wait with this patch until the upstreaming is finished. The reason is not only to do with upstreaming, but also with a concurrent effort to button up any assertion and runtime errors so the initial user experience is better.

[PATCH] D122008: [flang][driver] Add support for generating executables

clementval added a comment. In D122008#3426847 , @awarzynski wrote: > We discussed this patch in our community call today and some people expressed > their reservations about merging this just now. As I mentioned, I would like > to have this merged to

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. We discussed this patch in our community call today and some people expressed their reservations about merging this just now. As I mentioned, I would like to have this merged to unblock the CMake PR . As

[PATCH] D122008: [flang][driver] Add support for generating executables

Leporacanthicus accepted this revision. Leporacanthicus added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 ___ cfe-commits mailing list

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 418580. awarzynski added a comment. Herald added a subscriber: MaskRay. Use llvm_add_library instead of add_flang_library Fortran_main should be a static library, but `add_flang_library` does not parse `STATIC` in `add_flang_library(Fortran_main STATIC

[PATCH] D122008: [flang][driver] Add support for generating executables

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 416513. awarzynski added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski created this revision. awarzynski added reviewers: kiranchandramohan, clementval. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert.