[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

This revision was automatically updated to reflect the committed changes. Closed by commit rGecf5924eb4c4: [clang-tidy] Add a useful note about -std=c++11-or-later (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal added a comment. Thanks for the review, sorry about the mistakes I made on this trivial change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771 ___

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++(98|11|14|17|20)[-or-later]: +This flag will cause multiple runs within the same check_clang_tidy +execution. Make sure you don't have shared state across

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal updated this revision to Diff 431141. steakhal marked an inline comment as done. steakhal added a comment. Make the note more precise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771 Files:

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++(98|11|14|17|20)[-or-later]: +This flag will cause multiple runs within the same check_clang_tidy +execution. Make sure you don't have shared state

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal updated this revision to Diff 431028. steakhal marked 2 inline comments as done. steakhal added a comment. Generalized the flag help text to all supported standard versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:22 [-check-suffixes=] \ +[-std=(c++11-or-later|c++17)] \ \ These aren't the only two valid options for this argument Valid values

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added a comment. In D125771#3525252 , @njames93 wrote: > Tbh the whole testing infrastructure for clang-tidy is a mess. When I have > wanted to verify fixes and diagnostics for header files, I find manually > invoking clang-tidy is

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

njames93 added a comment. Tbh the whole testing infrastructure for clang-tidy is a mess. When I have wanted to verify fixes and diagnostics for header files, I find manually invoking clang-tidy is better than using the check_clang_tidy script. I don't have the time right now, but a verify mode

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

whisperity added a comment. In D125771#3519606 , @LegalizeAdulthood wrote: > I thought there wasn't any support for validating fixits applied to header > files? It is not specifically about the fixits, but diagnostics as a whole. It was not clear

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added a comment. I thought there wasn't any support for validating fixits applied to header files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal updated this revision to Diff 430069. steakhal marked an inline comment as done. steakhal added a comment. fix typo `withing` -> `within` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125771/new/ https://reviews.llvm.org/D125771 Files:

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

martong added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:31 + -std=c++11-or-later: +This flag will cause multiple runs withing the same check_clang_tidy +execution. Make sure you don't have shared state across these runs.

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

steakhal created this revision. steakhal added reviewers: aaron.ballman, whisperity, LegalizeAdulthood, alexfh. Herald added subscribers: martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a