This revision was automatically updated to reflect the committed changes.
Closed by commit rGd597a461e0f5: [clang][ASTImporter] Add support for import of
UsingPackDecl. (authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks! And sorry for the delay in the review, please ping me next time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125986/new/
balazske updated this revision to Diff 430990.
balazske added a comment.
Use of addDeclToContexts, added new test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125986/new/
https://reviews.llvm.org/D125986
Files:
clang/lib/AST/ASTImporter.cpp
balazske added a reviewer: martong.
balazske added inline comments.
Herald added a subscriber: rnkovacs.
Comment at: clang/lib/AST/ASTImporter.cpp:4861
+ ToUsingPack->setLexicalDeclContext(LexicalDC);
+ LexicalDC->addDeclInternal(ToUsingPack);
+
martong wrote:
martong added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:4861
+ ToUsingPack->setLexicalDeclContext(LexicalDC);
+ LexicalDC->addDeclInternal(ToUsingPack);
+
Why don't we use `addDeclToContexts`?
Comment at:
balazske created this revision.
Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: All.
balazske requested review of this revision.
Herald added a project: clang.
Herald added a
