[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG563cc3fda9a2: [Clang][CSKY] Add support about CSKYABIInfo (authored by zixuan-wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 ___ cfe-commits mailing

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu updated this revision to Diff 432820. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/CSKY/csky-abi.c clang/test/CodeGen/CSKY/csky-hard-abi.c

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

rengolin added a comment. In D126451#3541590 , @zixuan-wu wrote: > I don't think it is largely similar to RISCV implementation except for the > code structure and test reuse. And the test result is big different. Sorry, that's what I meant. There are

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. BTW, I have run llvm-test-suite, it passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:11708 + case llvm::Triple::csky: { +bool IsSoftFloat = !getTarget().hasFeature("hard-float-abi"); +bool hasFP64 = getTarget().hasFeature("fpuv2_df") || DavidSpickett wrote: >

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. In D126451#3539656 , @rengolin wrote: > This looks good to me, but wait to make sure others see it, too. > > My reasons are: it is largely similar to RISCV implementation, it seems to > follow what I expected of the ABI (which

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

DavidSpickett added a comment. Looks good to me. Can you just clarify how the tests are split? My guess is that one is stuff that doesn't vary with hard/soft float and the other is the bits that change when hardfloat is enabled. If so is it worth checking those situations with soft float too

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

rengolin added a comment. This looks good to me, but wait to make sure others see it, too. My reasons are: it is largely similar to RISCV implementation, it seems to follow what I expected of the ABI (which is similar to other targets) and has a large corpus of tests. I can't comment on the

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. In D126451#3539512 , @DavidSpickett wrote: > Can you reupload with more context? See > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > > I doubt I'll be able to give any in depth review but

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu updated this revision to Diff 432228. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/CSKY/csky-abi.c clang/test/CodeGen/CSKY/csky-hard-abi.c Index:

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

DavidSpickett added a comment. Can you reupload with more context? See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface I doubt I'll be able to give any in depth review but if things look good generally I'm sure you'll find the issues through your own testing as

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, DavidSpickett. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the CSKY ABIv2 document