[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-18 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config eagerly-assume=false -verify %s +// REQUIRES: no-z3 ASDenysPetrov wrote: > martong wrote:

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-15 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov closed this revision. ASDenysPetrov added a comment. Closed with bc08c3cb7f8e797fee14e96eedd3dc358608ada3 Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-15 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129498/new/ https://reviews.llvm.org/D129498 ___ cfe-commits mailing list

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-14 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 444689. ASDenysPetrov added a comment. Stick to name `clang_analyzer_value`. Change function name from `printRange` to `printValue`. Make description more precise in the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129498/new/

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-14 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Very good! In D129498#3650595 , @NoQ wrote: > In D129498#3647348 , @ASDenysPetrov > wrote: > >> In D129498#3644222 , @NoQ wrote: >> >>> Maybe

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D129498#3647348 , @ASDenysPetrov wrote: > In D129498#3644222 , @NoQ wrote: > >> Maybe `clang_analyzer_range()` instead? > > This was its first name. I refused. First, because it emits

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-13 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 444336. ASDenysPetrov added a comment. Constrained the test by adding llvm-lit `REQUIRES` command. Documented a new function at https://clang.llvm.org/docs/analyzer/developer-docs/DebugChecks.html CHANGES SINCE LAST ACTION

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-13 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. In D129498#3644222 , @NoQ wrote: > Looks great! > > Maybe `clang_analyzer_range()` instead? This was its first name. I refused. First, because it emits concrete integers as well and moreover we can extend it for arrays or

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Looks great! Maybe `clang_analyzer_range()` instead? Please add documentation to https://clang.llvm.org/docs/analyzer/developer-docs/DebugChecks.html Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

2022-07-11 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ, Charusso. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a