[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb7d76d65e8: [coroutine] add nomerge function attribute to `llvm.coro.save` (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen added a comment. In D129530#3644094 , @ChuanqiXu wrote: > In D129530#3644091 , @ychen wrote: > >> In D129530#3644074 , @ChuanqiXu >> wrote: >> >>> This looks good

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen updated this revision to Diff 443818. ychen added a comment. - Address Chuanqi's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129530/new/ https://reviews.llvm.org/D129530 Files: clang/test/CodeGenCoroutines/coro-attributes.cpp

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D129530#3644091 , @ychen wrote: > In D129530#3644074 , @ChuanqiXu > wrote: > >> This looks good to

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen added a comment. In D129530#3644074 , @ChuanqiXu wrote: > This looks good to me basically. I would love to see an example to test the > two coro.save wouldn't be merged. Yep, `hoist-skip-token.ll` is testing this. Repository: rG LLVM Github

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ChuanqiXu added a comment. This looks good to me basically. I would love to see an example to test the two coro.save wouldn't be merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129530/new/ https://reviews.llvm.org/D129530

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen created this revision. ychen added reviewers: nikic, ChuanqiXu. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. It is illegal to