[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83ea47acd711: [test] Make tests pass regardless of gnu++14/gnu++17 default (authored by MaskRay). Changed prior to commit:

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 457367. MaskRay marked 2 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Fix a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM but I'd appreciate it if @dblaikie could also give it a once over so we have more than one sets of eyes on the changes in case I've missed something.

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:570 +clang_std_values = ('98', '11', '14', '17', '20', '2b') +def add_stdcxx(s): +t = s[8:] aaron.ballman wrote: >

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/exception-spec-decay.cpp:1 -// RUN: %clang_cc1 -fcxx-exceptions -fexceptions %s -triple=i686-unknown-linux -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %stdcxx_98- -fcxx-exceptions -fexceptions

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 456524. MaskRay marked 6 inline comments as done. MaskRay added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files:

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. I like the direction this is going; I ran into some questions on the tests about whether we should use a range or not and other small things, but I think this is getting close. Comment at: clang/test/CXX/temp/temp.res/temp.local/p3.cpp:2 +//

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 454282. MaskRay marked 6 inline comments as done. MaskRay added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files:

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. In D131464#3716905 , @MaskRay wrote: > Sorry, my previous main comment had been written before I introduced > `LIT_CLANG_STD_GROUP` in `llvm/utils/lit/lit/llvm/config.py`. The multiple > `%clang_cc1` approach actually

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added a comment. Sorry, my previous main comment had been written before I introduced `LIT_CLANG_STD_GROUP` in `llvm/utils/lit/lit/llvm/config.py`. The multiple `%clang_cc1` approach actually looks like the following. Note the use of `%stdcxx_17-` to make the test future-proof. (It is

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. In D131464#3713705 , @MaskRay wrote: > It will take some time to fix all tests properly. Let's have a guideline how > to fix them properly. I tried fixing some using several patterns in the last > revision. I didn't fix

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

dblaikie added a comment. > I use something like > > // RUN: %clang_cc1 %s -fsyntax-only -verify=expected,precxx17 -std=c++14 > -fdata-sections -fcolor-diagnostics > // RUN: %clang_cc1 %s -fsyntax-only -verify -std=c++17 -fdata-sections > -fcolor-diagnostics > > ... >

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added a comment. It will take some time to fix all tests properly. Let's have a guideline how to fix them properly. I tried fixing some using several patterns in the last revision. I didn't fix all, because it would likely lead to an unsatisfactory result and I would spend more time :)

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 451586. MaskRay marked 5 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Add lit substitutions Repository: rG LLVM Github

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. I didn't do a full review because I spotted enough concerns that we might want to talk about the approach more first. I think the goal should be to avoid adding a `-std=` to any RUN line unless the test really requires it. I spotted a lot of instances where we

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 451377. MaskRay added a comment. fix some tests in a better way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files: clang/lib/Basic/LangStandards.cpp

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

junaire added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

junaire added a comment. I wonder what's the difference between this patch and https://reviews.llvm.org/D124434 ? Also add some reviewers that get involved in the previous discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay created this revision. MaskRay added a reviewer: clang-language-wg. Herald added subscribers: bzcheeseman, StephenFan, mstorsjo. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.