This revision was automatically updated to reflect the committed changes.
Closed by commit rG5482432bf6cc: [clang][deps] Compute command-lines for
dependencies immediately (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
benlangmuir marked 2 inline comments as done.
benlangmuir added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:403
+
+static std::string getModuleCachePath(ArrayRef Args) {
+ for (StringRef Arg : llvm::reverse(Args)) {
jansvoboda11
benlangmuir updated this revision to Diff 453085.
benlangmuir edited the summary of this revision.
benlangmuir added a comment.
Per review
- Add typedef for callback type
- Add comment about mapping paths to "-"
- Update commit message for module cache path computation change
CHANGES SINCE
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM overall with some minor nitpicks.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:95
+ const llvm::StringSet<> ,
+
benlangmuir created this revision.
benlangmuir added a reviewer: jansvoboda11.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Instead of delaying the generation of command-lines to after all
