pengfei added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859
}
-return getIndirectResult(Ty, /*ByVal=*/false, State);
+bool ByVal = IsVectorCall && Ty->isFloatingType();
+return getIndirectResult(Ty, ByVal, State);
}
pengfei updated this revision to Diff 465391.
pengfei added a comment.
Address @rnk's comments. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134797/new/
https://reviews.llvm.org/D134797
Files:
clang/lib/CodeGen/TargetInfo.cpp
rnk added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859
}
-return getIndirectResult(Ty, /*ByVal=*/false, State);
+bool ByVal = IsVectorCall && Ty->isFloatingType();
+return getIndirectResult(Ty, ByVal, State);
}
pengfei added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859
}
-return getIndirectResult(Ty, /*ByVal=*/false, State);
+bool ByVal = IsVectorCall && Ty->isFloatingType();
+return getIndirectResult(Ty, ByVal, State);
}
pengfei updated this revision to Diff 464892.
pengfei added a comment.
Add HFA test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134797/new/
https://reviews.llvm.org/D134797
Files:
clang/lib/CodeGen/TargetInfo.cpp
rnk added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859
}
-return getIndirectResult(Ty, /*ByVal=*/false, State);
+bool ByVal = IsVectorCall && Ty->isFloatingType();
+return getIndirectResult(Ty, ByVal, State);
}
I
pengfei created this revision.
pengfei added a reviewer: rnk.
Herald added a project: All.
pengfei requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The passing format of floating-point types are different from vector when SSE
registers
