[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski added a comment. In D134821#4317371 , @peixin wrote: >> @peixin , wdyt? > > @awarzynski Hi Andrzej, sorry for the late reply. I am distracted by several > internal projects and other things in my life recently (just came back from >

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

peixin added a comment. > @peixin , wdyt? @awarzynski Hi Andrzej, sorry for the late reply. I am distracted by several internal projects and other things in my life recently (just came back from vacation). My boss has not decided to let me continue working on LLVM Flang this year, yet.

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce added a comment. In D134821#4304690 , @awarzynski wrote: > I've just reverted this patch - for context please see > https://reviews.llvm.org/D149429. > > @sunshaoce This was committed >

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski added a comment. I've just reverted this patch - for context please see https://reviews.llvm.org/D149429. @sunshaoce This was committed without acknowledging @ekieri 's contribution, so didn't follow the official

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876df74dd471: [flang][driver] Allow main program to be in an archive (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski accepted this revision. awarzynski added a comment. In D134821#4301701 , @sunshaoce wrote: > Any further suggestions? I am happy for you to land this, thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce added a comment. Any further suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce updated this revision to Diff 516651. sunshaoce added a comment. Address @awarzynski's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski added a comment. Thanks for all the great effort, @ekieri ! @sunshaoce , mostly makes sense, just a few small suggestions. @peixin , wdyt? Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:601-603 +// A Fortran main program will be lowered to a function named

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce updated this revision to Diff 516476. sunshaoce added a comment. This revision is now accepted and ready to land. Herald added subscribers: pcwang-thead, s.egerton, simoncook, asb. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce added a comment. I would like to help land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri abandoned this revision. ekieri added a comment. Herald added a subscriber: sunshaoce. Sorry to drop out on this. I got interrupted by other duties in life, and now I am no longer able to continue this work. If anybody wants to pick up the ball from here, please feel free to commandeer

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

peixin added a comment. Please fix the clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Great stuff @ekieri , thanks for doing this! You may want add a note in the summary that you've updated the docs as well. This is consistent with what we discussed in

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri updated this revision to Diff 463998. ekieri added a comment. Fix test link-f90-main.f90, which was failing for statically linked builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files:

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri added a comment. CI fail noted, update will come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri created this revision. ekieri added reviewers: awarzynski, peixin, sscalpone. Herald added projects: Flang, All. ekieri requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. Add --undefined=_QQmain to the link line, so