[PATCH] D140250: Define NULL in its own header

iana abandoned this revision. iana added a comment. This was succeeded by D158709 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. In D140250#4081133 , @iana wrote: > In D140250#4081119 , @rsmith wrote: > >> In D140250#4081102 , @rsmith

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4081119 , @rsmith wrote: > In D140250#4081102 , @rsmith wrote: > >> Our builtin header `stddef.h` shouldn't be built as a module. It >> fundamentally needs to be treated as a

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. In D140250#4081102 , @rsmith wrote: > Our builtin header `stddef.h` shouldn't be built as a module. It > fundamentally needs to be treated as a textual header, because it consumes > macros defined by the includer. The module map

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. In D140250#4081009 , @iana wrote: > In D140250#4080990 , @rsmith wrote: > >> Wait a second... if an OS wants only `NULL`, we already have a supported way >> of achieving that, which is

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4081044 , @aaron.ballman wrote: > In D140250#4081009 , @iana wrote: > >> In D140250#4080990 , @rsmith wrote: >> >>> Wait a second... if

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. In D140250#4081009 , @iana wrote: > In D140250#4080990 , @rsmith wrote: > >> Wait a second... if an OS wants only `NULL`, we already have a supported way >> of achieving that,

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4080990 , @rsmith wrote: > Wait a second... if an OS wants only `NULL`, we already have a supported way > of achieving that, which is compatible with GCC and glibc and other POSIX > compilers -- define `__need_NULL`

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. Wait a second... if an OS wants only `NULL`, we already have a supported way of achieving that, which is compatible with GCC and glibc and other POSIX compilers -- define `__need_NULL` before including the header. We shouldn't be providing internal headers with

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. Please be sure to add a release note when landing the changes, btw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 ___

[PATCH] D140250: Define NULL in its own header

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 492179. iana added a comment. Revert the unnecessary changes to unspecified-var-size.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D140250: Define NULL in its own header

dblaikie added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line:

[PATCH] D140250: Define NULL in its own header

aaron.ballman added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7,

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D140250: Define NULL in its own header

dblaikie added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line:

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4077974 , @iana wrote: > In D140250#4077956 , @aaron.ballman > wrote: > >> In D140250#4077826 , @iana wrote: >> >>> In D140250#4076851

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491869. iana added a comment. Add an explicit header test for __stddef_null.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4077956 , @aaron.ballman wrote: > In D140250#4077826 , @iana wrote: > >> In D140250#4076851 , >> @aaron.ballman wrote: >> >>> I'd

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. In D140250#4077826 , @iana wrote: > In D140250#4076851 , @aaron.ballman > wrote: > >> I'd expect there to be a test under `clang/test/Headers/` showing that this >> new header

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4076851 , @aaron.ballman wrote: > I'd expect there to be a test under `clang/test/Headers/` showing that this > new header works as expected. It's covered pretty well by stddefneeds.cpp already. I can add a new one if

[PATCH] D140250: Define NULL in its own header

aaron.ballman added subscribers: echristo, dblaikie, aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I'd expect there to be a test under `clang/test/Headers/` showing that this new header works as expected. Comment at:

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491644. iana added a comment. Fix the broken tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491607. iana added a comment. Fix the debuginfo-generic-assignment-tracking-sroa test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files:

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 491604. iana added a comment. Rebase, update diagnostic to include the full module name instead of just the top level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. I think this should be all we need, but I'm still running tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 486100. iana added a comment. Herald added subscribers: llvm-commits, Sanitizers, Enna1, kadircet, arphaman. Herald added projects: Sanitizers, LLVM, clang-tools-extra. Add a module for __stddef_null.h and give it the same special treatment as

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. This needs a bit more work, it looks like it's not enough to just add a header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:15 +#ifdef __cplusplus +#if !defined(__MINGW32__) && !defined(_MSC_VER) +#define NULL __null `arc lint` wanted to remove all of the indentation that was in stddef.h. Repository: rG

[PATCH] D140250: Define NULL in its own header

iana created this revision. iana added reviewers: ributzka, vsapsai, Bigcheese. Herald added a subscriber: mstorsjo. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make a new header to define NULL so that