[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

This revision was automatically updated to reflect the committed changes. Closed by commit rGe43295209bb8: [clang-tidy] Match derived types in in modernize-loop-convert (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter added a comment. Rebased! Sorry for the multiple diffs on this phab - I'm still getting the hang of `arc diff`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter updated this revision to Diff 487781. ccotter added a comment. rebase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter updated this revision to Diff 487778. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 Files: clang-tools-extra/docs/ReleaseNotes.rst Index:

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

carlosgalvezp added a comment. Hi! I'm finding merge conflicts when rebasing the patch on latest trunk, would you mind uploading a rebased version? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, let's give @njames93 a few days in case he has some comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 +

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), +

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), +

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter updated this revision to Diff 486716. ccotter added a comment. - Match derived types in in modernize-loop-convert - fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 Files:

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), + hasMethod(cxxMethodDecl(hasName("end"), +

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter updated this revision to Diff 485637. ccotter added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 Files: