[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson closed this revision. royjacobson added a comment. Landed in https://github.com/llvm/llvm-project/commit/be701ab08f12daf9437c2db6d08a1731cf1df34c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this, the new layout is a big improvement! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a subscriber: clang-language-wg. royjacobson marked 2 inline comments as done. royjacobson added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 496771. royjacobson added a comment. Rebase to include the RISC-V changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43 + conforming GNU extensions. Projects incompatible with C++17 can add + ``-std=gnu++14`` to their build settings to restore the previous behaviour. royjacobson wrote: >

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:16 Release notes for previous releases can be found on - `the Download Page `_. + `the Releases Page `_.

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 493360. royjacobson marked 2 inline comments as done. royjacobson added a comment. 15 -> Clang 15 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 Files:

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added a comment. Thank you for working on this, it is really shaping up nicely! In D142578#4088769 , @royjacobson wrote: > In D142578#4088011 , @tschuett > wrote: > >> IDK. Clang 16 is fully is a

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson marked an inline comment as done. royjacobson added a comment. In D142578#4088011 , @tschuett wrote: > IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or > beginning with Clang 16, we start a long-term project to

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson marked 5 inline comments as done. royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 493008. royjacobson added a comment. - Remove redundant paragraph from the intro - Remove outdated bug fix bullet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

tschuett added a comment. IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or beginning with Clang 16, we start a long-term project to overhaul the diagnostics. I agree that breaking changes are important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. In D142578#4087974 , @tschuett wrote: > I am not the only one who has a different background. If the introduction > says this is the introduction of the release notes, I am not super motivated > to read on. I would prefer

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

tschuett added a comment. I am not the only who has a different background. If the introduction says this is the introduction of the release notes, I am not super motivated to read on. I would prefer to see some highlights to motivate the readers to continue reading. Repository: rG LLVM

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang extension. aaron.ballman

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang extension. Assuming

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I think it's worthwhile to mark comments with the "Done" checkmark in Phrabricator if they have been addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. Thanks Erich and Emilia! The html file is attached here, I think it's probably easier to proof read that way. (Took me a bit to figure out the CMake magic...) F26271094: ReleaseNotes.html Repository: rG LLVM Github Monorepo

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 492516. royjacobson added a comment. - Address comments from Erich and Emilia - Validate that the rst actually builds an html file - Fix some missing backticks and underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

erichkeane added a comment. A handful of suggestions as I spot-checked. This looks great, thank you for doing this! I'd like Aaron to take a look though. Comment at: clang/docs/ReleaseNotes.rst:51 +- The ``-fexperimental-new-pass-manager`` and ``-fno-legacy-pass-manager`` +

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I don't know sphinx enough to know if the trailing underscore is needed in links, but there's about 5 links that don't have the underscore (Search for >`) ) Comment at: clang/docs/ReleaseNotes.rst:577 + potential false positives, this diagnostic

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, dschuff. Herald added a project: All. royjacobson requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added