[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

aaron.ballman added a comment. My primary concern with this is that we're calling these stable IDs -- they're not really stable IDs, they're internal implementation details that we change from time to time. So what happens when we rename `ext_foo_bar` into `warn_foo_bar` as far as SARIF is

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

Endill added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

vaibhav.y added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

denik added inline comments. Comment at: clang/lib/Basic/DiagnosticIDs.cpp:103 +// Stable names +const char *const StaticDiagInfoStableNames[] = { +#define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR, \ As of now it's 4600 strings,

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507510. cjdb added a comment. I think this corrects everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files: clang/include/clang/Basic/Diagnostic.h

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507503. cjdb edited the summary of this revision. cjdb added a comment. rebasing continues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files:

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507494. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files:

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb created this revision. cjdb added reviewers: aaron.ballman, vaibhav.y, denik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per §3.27.5 and §3.27.7, the `rule.id` and `ruleId` properties need to be