[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2b256a99059: Reapply [clang] [test] Narrow down MSVC specific behaviours from any windows… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

aaron.ballman accepted this revision. aaron.ballman added a comment. In D149997#4338897 , @mstorsjo wrote: > Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda > ugly way of checking for an MSVC-like environment specifically

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo updated this revision to Diff 521781. mstorsjo added a comment. Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda ugly way of checking for an MSVC-like environment specifically (when the MSVC mode is the exception compared with the rest), but neither

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a comment. In D149997#4338304 , @rnk wrote: > I think `_MSC_EXTENSIONS` will work, but it's kind of gross. `_MSC_VER` is > controlled by `-fms-compatibility-verson=`, which I think is off by default > or unset at the cc1 level: >

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

rnk added a comment. In D149997#4337548 , @mstorsjo wrote: > So, the reason why this failed, is that when invoked as `%clang_cc1` in a > MSVC/clang-cl style build, `_MSC_VER` isn't predefined, while `_WIN32` is. > When invoked via the Clang driver

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a subscriber: rnk. mstorsjo added a comment. So, the reason why this failed, is that when invoked as `%clang_cc1` in a MSVC/clang-cl style build, `_MSC_VER` isn't predefined, while `_WIN32` is. When invoked via the Clang driver instead of directly going at `-cc1`, `_MSC_VER`

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a comment. In D149997#4331937 , @thakis wrote: > This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt > > (The Driver/split-debug.c failure is something else and since fixed, but the > other two tests are due to this

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. Fails with cmake too: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8781510258907322449/+/u/package_clang/stdout?format=raw Reverted in 56bac6c87a2d9046dbac36aae4910b4b90edf643

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt (The Driver/split-debug.c failure is something else and since fixed, but the other two tests are due to this change.) Please take a look and revert for now if it takes a while to fix.

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f037e5645bd: [clang] [test] Narrow down MSVC specific behaviours from any windows to only… (authored by mstorsjo). Repository: rG LLVM Github

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149997/new/ https://reviews.llvm.org/D149997 ___

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, hans. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This fixes running tests with a toolchain that defaults to a MinGW target. Repository: rG LLVM Github Monorepo