[PATCH] D153989: [compiler-rt] Move crt into builtins

arichardson added a comment. In D153989#4492342 , @phosek wrote: > In D153989#4492229 , @arichardson > wrote: > >> I think reduplication of build logic makes sense but these are conceptually >> separate things.

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4494278 , @phosek wrote: > Thanks for this heads up, this should be addressed in > rG926f3759ec62a8f170e76a60316cc0bdd9dd2ec9 > . That didn't work,

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4494012 , @nathanchance wrote: > This change appears to break `-DCOMPILER_RT_BUILD_CRT=OFF`: > > $ cmake -B build -S llvm -DCMAKE_BUILD_TYPE=Release > -DCOMPILER_RT_BUILD_CRT=OFF

[PATCH] D153989: [compiler-rt] Move crt into builtins

nathanchance added a comment. This change appears to break `-DCOMPILER_RT_BUILD_CRT=OFF`: $ cmake -B build -S llvm -DCMAKE_BUILD_TYPE=Release -DCOMPILER_RT_BUILD_CRT=OFF -DLLVM_ENABLE_PROJECTS='clang;compiler-rt;lld' ... CMake Error at cmake/modules/AddLLVM.cmake:1935 (add_dependencies):

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4492229 , @arichardson wrote: > I think reduplication of build logic makes sense but these are conceptually > separate things. The compiler rt builtins are needed in many cases where the > C start-up code isn't (e.g.

[PATCH] D153989: [compiler-rt] Move crt into builtins

arichardson added a comment. I think reduplication of build logic makes sense but these are conceptually separate things. The compiler rt builtins are needed in many cases where the C start-up code isn't (e.g. baremetal OS code). Would moving it to a subdirectory of builtins/ work too? That

[PATCH] D153989: [compiler-rt] Move crt into builtins

sylvestre.ledru added a comment. Seems that it caused: https://github.com/llvm/llvm-project/issues/63799 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 ___

[PATCH] D153989: [compiler-rt] Move crt into builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. phosek marked an inline comment as done. Closed by commit rGdae9d1b52469: [compiler-rt] Move crt into builtins (authored by phosek). Changed prior to commit:

[PATCH] D153989: [compiler-rt] Move crt into builtins

smeenai added a comment. In D153989#4465907 , @phosek wrote: > In D153989#4465759 , @smeenai wrote: > >> Sorry, it's been a week :D I assume that crt doesn't need the builtins to be >> available for its

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4465759 , @smeenai wrote: > Sorry, it's been a week :D I assume that crt doesn't need the builtins to be > available for its configure (the way the rest of compiler-rt does)? If so, > this LGTM. Great question, I

[PATCH] D153989: [compiler-rt] Move crt into builtins

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry, it's been a week :D I assume that crt doesn't need the builtins to be available for its configure (the way the rest of compiler-rt does)? If so, this LGTM.

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. @smeenai Do you have any opinion on this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 ___ cfe-commits mailing list

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek updated this revision to Diff 535452. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 Files: compiler-rt/CMakeLists.txt compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/lib/CMakeLists.txt

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek created this revision. phosek added reviewers: smeenai, beanz. Herald added subscribers: Enna1, abrachet, dberris. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. On Linux