This revision was automatically updated to reflect the committed changes.
Closed by commit rGfa1dc06a1b39: [clang][X86] Update excessive register save
diagnostic to more closely follow… (authored by antangelo, committed by
pengfei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
antangelo added a comment.
Thank you for the quick reviews! I don't have currently have commit access to
commit the changes myself, is it possible for someone to commit on my behalf?
My name and email are:
Name: Antonio Abbatangelo
Email: cont...@antangelo.com
Repository:
rG LLVM Github
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
I don't have prior experience about interrupt diagnostic but know something
about mgeneral-regs-only. I think the diagnostic great.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:317
+ " with attribute 'no_caller_saved_registers'"
+ " or be compiled with '-mgeneral-regs-only'">,
+ InGroup>;
pengfei wrote:
> aaron.ballman wrote:
> > Can
pengfei added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:317
+ " with attribute 'no_caller_saved_registers'"
+ " or be compiled with '-mgeneral-regs-only'">,
+ InGroup>;
aaron.ballman wrote:
> Can you add a test case showing
aaron.ballman edited reviewers, added: pengfei; removed: mibintc.
aaron.ballman added a comment.
Changing the reviewers up a bit; the changes generally seem reasonable to me,
but I'd appreciate some x86 reviewer viewpoints.
Comment at:
antangelo created this revision.
antangelo added reviewers: erichkeane, aaron.ballman, mibintc.
Herald added a project: All.
antangelo requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The original diagnostic does not cover all cases
