This revision was automatically updated to reflect the committed changes.
Closed by commit rL262996: Accept absolute paths in the -fuse-ld option.
(authored by whitequark).
Repository:
rL LLVM
http://reviews.llvm.org/D17952
Files:
cfe/trunk/lib/Driver/ToolChain.cpp
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
whitequark updated this revision to Diff 50097.
whitequark added a comment.
Added a test
Repository:
rL LLVM
http://reviews.llvm.org/D17952
Files:
cfe/trunk/lib/Driver/ToolChain.cpp
cfe/trunk/test/Driver/fuse-ld.c
Index: cfe/trunk/test/Driver/fuse-ld.c
echristo added a subscriber: echristo.
echristo added a comment.
Needs a testcase, but otherwise should be fine.
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Testcases?
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:352
@@ +351,3 @@
+return UseLinker;
+} else {
+ // If we're passed -fuse-ld= with no argument, or with the argument ld,
Makes sense.
Repository:
rL LLVM
whitequark updated this revision to Diff 50021.
whitequark added a comment.
Windows compatibility
Repository:
rL LLVM
http://reviews.llvm.org/D17952
Files:
cfe/trunk/lib/Driver/ToolChain.cpp
Index: cfe/trunk/lib/Driver/ToolChain.cpp
silvas added a subscriber: silvas.
silvas added a comment.
Some nits but this looks fine to me. I've been wanting this for a while now.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:347
@@ +346,3 @@
+
+if (UseLinker[0] == '/') {
+ // If we're passed -fuse-ld= with
whitequark created this revision.
whitequark added a reviewer: majnemer.
whitequark added a subscriber: cfe-commits.
whitequark set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
This patch extends the -fuse-ld option to accept a full path to an executable
and
