dcoughlin closed this revision.
dcoughlin added a comment.
This was committed in r274691. I forgot to add the Differential Revision line
so phabricator didn't pick it up.
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
NoQ accepted this revision.
NoQ added a comment.
LGTM, all clear to me now :)
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin updated the summary for this revision.
dcoughlin updated this revision to Diff 62978.
dcoughlin added a comment.
Address Artem's comments: fix a copy-pasta mistake and separate out std stubs
with deliberate divide-by-zero bugs into their own simulated header file. This
required moving
dcoughlin added inline comments.
Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:349
@@ +348,3 @@
+// No warning is expected as we are suppressing warning coming
+// out of std::basic_string.
+int z = 0;
NoQ wrote:
> You mean
NoQ added inline comments.
Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:349
@@ +348,3 @@
+// No warning is expected as we are suppressing warning coming
+// out of std::basic_string.
+int z = 0;
You mean std::shared_ptr here?
Also,
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
The analyzer does not model C++ temporary destructors completely and so reports
false alarms about leaks of memory allocated by the
