This revision was automatically updated to reflect the committed changes.
Closed by commit rL275279: [include-fixer] Implement adding missing namespace
qualifiers in vim… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22299?vs=63808=63818#toc
Repository:
rL LLVM
hokein updated this revision to Diff 63808.
hokein marked an inline comment as done.
hokein added a comment.
Fix nits.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
One nit, LGTM.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:277
@@ +276,3 @@
+//
+// Check whether all elements in HeaderInfos have the qualified name.
+
hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+assert(!HeaderInfos.empty());
+// Only accept an unique header.
+bool IsUniqueHeader = std::equal(
bkramer wrote:
> In that case adjacent_find was the
hokein updated this revision to Diff 63799.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments for std::equal.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+assert(!HeaderInfos.empty());
+// Only accept an unique header.
+bool IsUniqueHeader = std::equal(
In that case adjacent_find was the right choice,
hokein marked an inline comment as done.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+// Only accept an unique header.
+bool IsUniqueHeader =
+std::adjacent_find(HeaderInfos.begin(), HeaderInfos.end(),
You are right.
hokein updated this revision to Diff 63796.
hokein marked 6 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
bkramer added inline comments.
Comment at: include-fixer/IncludeFixerContext.cpp:54
@@ +53,3 @@
+llvm::StringRef Name, llvm::StringRef ScopeQualifiers,
+const std::vector Symbols,
+tooling::Range Range)
Drop the const ...
Comment at:
