[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-11-10 Thread Artem Dergachev via cfe-commits
NoQ added a comment. Maybe you could instead make a checker that subscribes for `checkEndAnalysis` and scans the provided `ExplodedGraph`'s `nodes_begin()..nodes_end()` for visited statement-based program points (as in `PathDiagnosticLocation::getStmt(N)`)? This should give you per-statement

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-11-10 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262 + +static void dumpCoverageInfo(llvm::SmallVectorImpl , + SourceManager ) { xazax.hun wrote: > zaks.anna wrote: > > xazax.hun wrote: > > >

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-11-10 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262 + +static void dumpCoverageInfo(llvm::SmallVectorImpl , + SourceManager ) { zaks.anna wrote: > xazax.hun wrote: > > zaks.anna wrote: > > > Can

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-11-09 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. > Added a python script to merge gcov files. When the patches that are being reviewed are growing new functionality, it's much more difficult to review them. Please, submit the python script as a separate patch. Comment at:

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-11-08 Thread Gábor Horváth via cfe-commits
xazax.hun updated the summary for this revision. xazax.hun updated this revision to Diff 77199. xazax.hun added a comment. - Added a python script to merge gcov files. - Fixed an error - Multifile test is not added yet, will do so in the next update. https://reviews.llvm.org/D25985 Files:

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-11-04 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D25985#580270, @zaks.anna wrote: > Please, add multi-file tests and tests where a line is covered more than once. Ok, I will add it in the next iteration. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262 + +static

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-10-26 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:274 +if (Invalid) + continue; +std::ofstream OutFile(FilePath.c_str()); zaks.anna wrote: > Would it be better to break if the buffer is invalid? > Should this be

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-10-26 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Please, add multi-file tests and tests where a line is covered more than once. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262 + +static void dumpCoverageInfo(llvm::SmallVectorImpl , + SourceManager ) {

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-10-26 Thread Gábor Horváth via cfe-commits
xazax.hun removed rL LLVM as the repository for this revision. xazax.hun updated this revision to Diff 75923. https://reviews.llvm.org/D25985 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h lib/StaticAnalyzer/Core/AnalyzerOptions.cpp lib/StaticAnalyzer/Core/ExprEngine.cpp

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

2016-10-26 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, NoQ, a.sidorin, dcoughlin. xazax.hun added subscribers: cfe-commits, dkrupp, o.gyorgy, szepet. xazax.hun set the repository for this revision to rL LLVM. This patch adds a new option to export an optimistic basic block