This revision was automatically updated to reflect the committed changes.
Closed by commit rL288375: [clang-tidy] Rename modernize-use-default to
modernize-use-equals-default (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26511?vs=79919&id=79928#toc
Repositor
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
https://reviews.llvm.org/D26511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
malcolm.parsons updated this revision to Diff 79919.
malcolm.parsons added a comment.
Re-remove doubled space in modernize-use-equals-default.rst.
https://reviews.llvm.org/D26511
Files:
clang-tidy/add_new_check.py
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModul
malcolm.parsons updated this revision to Diff 79918.
malcolm.parsons added a comment.
Herald added a subscriber: JDevlieghere.
Add documentation redirect.
Change add_new_check.py to ignore checks that are orphaned.
https://reviews.llvm.org/D26511
Files:
clang-tidy/add_new_check.py
clang-tid
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFa
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
malcolm.parsons updated this revision to Diff 77615.
malcolm.parsons added a comment.
Fix sorting.
Mention in release notes.
https://reviews.llvm.org/D26511
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
c
aaron.ballman added a comment.
In https://reviews.llvm.org/D26511#592670, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26511#592665, @Prazek wrote:
>
> > It is introduced because of "modernize-use-delete" was too ambiguous
> > because of operator delete, so it was changed to
> > "mode
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26511#592665, @Prazek wrote:
> It is introduced because of "modernize-use-delete" was too ambiguous because
> of operator delete, so it was changed to "modernize-use-equals-delete". But
> this case is not ambiguous at all, so I don't
Prazek added a comment.
I think this change is not required at first place.
It is introduced because of "modernize-use-delete" was too ambiguous because of
operator delete, so it was changed to "modernize-use-equals-delete". But this
case is not ambiguous at all, so I don't see point changing th
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFact
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFa
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFact
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, angelgarcia.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D26511
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Moder
16 matches
Mail list logo
