This revision was automatically updated to reflect the committed changes.
Closed by commit rL289883: [analyzer] Include type name in Retain Count Checker
diagnostics (authored by zaks).
Changed prior to commit:
https://reviews.llvm.org/D27740?vs=81482&id=81668#toc
Repository:
rL LLVM
https:
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D27740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
zaks.anna updated this revision to Diff 81482.
zaks.anna added a comment.
Address Devin's comment regarding 'id'.
https://reviews.llvm.org/D27740
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
test/Analysis/edges-new.mm
test/Analysis/inlining/path-notes.m
test/Analysis/objc-a
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2000
+if (Sym->getType().isNull()) {
+ os << " returns an Objective-C object with a ";
+} else {
I think we should use this diagnostic text wh
zaks.anna updated this revision to Diff 81429.
zaks.anna added a comment.
Devin did not like the '*' in the diagnostic for ObjC objects, so remove the
'*'.
https://reviews.llvm.org/D27740
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
test/Analysis/edges-new.mm
test/Analysis/i
zaks.anna created this revision.
zaks.anna added a reviewer: dcoughlin.
zaks.anna added subscribers: cfe-commits, dcoughlin.
The more detailed diagnostic will make identifying which object the diagnostics
refer to easier.
https://reviews.llvm.org/D27740
Files:
lib/StaticAnalyzer/Checkers/Ret
