Anastasia closed this revision.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Committed in r 293286
https://reviews.llvm.org/D28814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D28814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Anastasia marked 2 inline comments as done.
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:3
// RUN: %clang_cc1 %s -cl-std=CL2.0 -ffake-address-space-map -O0 -emit-llvm -o
- -triple "spir64-unknown-unknown" | FileCheck %s --check-pre
Anastasia updated this revision to Diff 85888.
Anastasia added a comment.
Updated NULL ptr generation and added separate CodeGen test for checking
amended Block generation behaviour in OpenCL!
https://reviews.llvm.org/D28814
Files:
lib/AST/Expr.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CG
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
-
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:726
+ CGM.getNSConcreteStackBlock()->getType()),
+ QualType());
isa = llvm::ConstantExpr::getBitCast(isa, VoidPtrTy);
The QualTyp
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
--
Anastasia updated this revision to Diff 85753.
Anastasia added a comment.
Switched to getNullPointer helper.
https://reviews.llvm.org/D28814
Files:
lib/AST/Expr.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/cl20
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:723
+? CGM.getNSConcreteStackBlock()
+: llvm::Constant::getNullValue(
+ CGM.getNSConcreteStackBlock()->getType());
-
Anastasia added a comment.
Ping! @yaxunl, Sam do you think you will have time to look into this?
https://reviews.llvm.org/D28814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia created this revision.
ObjC IR generation for Blocks currently:
I. Generates local to block variable declaration block literal in case it
contains captures.
II. Global variable block literal in case it doesn't have any captures.
The address spaces are missing however if we use this gen
11 matches
Mail list logo