[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-16 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode closed this revision. idlecode added a comment. Committed as r295113 https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-14 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. Committed as r295113. https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode added a comment. Yes, please. Thanks for you time :) https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. LGTM, do you need someone to commit for you? https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode updated this revision to Diff 88101. idlecode added a comment. Addressed Richard's inline comment. https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Frontend/LangStandard.h include/clang/Frontend/LangStandards.def

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Frontend/CompilerInvocation.cpp:1753-1754 + KindValue != LangStandard::lang_unspecified; + ++KindValue) + { +const

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode updated this revision to Diff 88100. idlecode added a comment. Displayed standards will now match processed file kind https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Frontend/LangStandard.h

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-10 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:233 "AddressSanitizer doesn't support linking with debug runtime libraries yet">; +def note_drv_supported_values : Note<"supported values are:">; +def

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-10 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode added a comment. Indeed, thanks :) I ran `make check-all` and had no errors so I thought there are no tests. Comment at: lib/Frontend/CompilerInvocation.cpp:1709 +Diags.Report(diag::note_drv_supported_value_with_description) + << Std.getName() <<

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-10 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode updated this revision to Diff 88029. idlecode added a comment. Added test, changed printout style a bit (but this still needs to be checked) https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Frontend/CompilerInvocation.cpp

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-09 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Test case? Comment at: lib/Frontend/CompilerInvocation.cpp:1709 +Diags.Report(diag::note_drv_supported_value_with_description) + << Std.getName() << Std.getDescription(); + } Is it possible to change the

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-08 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode created this revision. In case user did not provide valid standard name for `-std` option, available values (with short description) will be reported. To test: `clang -std=iso3103 -c source.c` https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td