[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

2017-04-19 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300689: [Driver] Unify linking of OpenMP runtime. NFCI. (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D30087?vs=94372&id=95733#toc Repository: rL LLVM https://reviews.llv

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

2017-04-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

2017-04-18 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Ping https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

2017-04-06 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 94372. Hahnfeld marked 2 inline comments as done. Hahnfeld retitled this revision from "[Driver] Unify linking of OpenMP runtime" to "[Driver] Unify linking of OpenMP runtime. NFCI.". Hahnfeld edited the summary of this revision. https://reviews.llvm.org/D30

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

2017-04-06 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430 +bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC, + const ArgList &Args, const JobAction &JA, + bool GompNeedsRT)

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-04-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430 +bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC, + const ArgList &Args, const JobAction &JA, + bool GompNeedsRT) {

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-04-03 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Ping! https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-27 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 93213. Hahnfeld added a comment. Herald added a subscriber: rengolin. Rebase and ping. https://reviews.llvm.org/D30087 Files: lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h lib/Driver/ToolChains/Darwin.cpp lib/Driver/ToolCh

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-20 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Another ping https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-08 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 90987. Hahnfeld added a comment. Rebase for recent refactoring and ping. https://reviews.llvm.org/D30087 Files: lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h lib/Driver/ToolChains/Darwin.cpp lib/Driver/ToolChains/FreeBSD.c

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-02 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 90295. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Reword comment https://reviews.llvm.org/D30087 Files: lib/Driver/Tools.cpp test/Driver/fopenmp.c Index: test/Driver/fopenmp.c =

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-01 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added inline comments. Comment at: lib/Driver/Tools.cpp:10334 - if (Args.hasFlag(options::OPT_fopenmp, options::OPT_fopenmp_EQ, - options::OPT_fno_openmp, false)) { + // FIXME: Exclude this for platforms with libgomp that don't require +

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-03-01 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Ping https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-02-20 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 89110. Hahnfeld added a comment. rebase https://reviews.llvm.org/D30087 Files: lib/Driver/Tools.cpp test/Driver/fopenmp.c Index: test/Driver/fopenmp.c === --- test/Driver/fopenmp.c +++ te

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-02-17 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: lib/Driver/Tools.cpp:8683 if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs)) -addOpenMPRuntime(CmdArgs, getToolChain(), Args); +addOpenMPRuntime(CmdArgs, getToolChain(), Args, JA); pirama

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-02-17 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added inline comments. Comment at: lib/Driver/Tools.cpp:8683 if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs)) -addOpenMPRuntime(CmdArgs, getToolChain(), Args); +addOpenMPRuntime(CmdArgs, getToolChain(), Args, JA); `addOpenM

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime

2017-02-17 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Herald added a subscriber: emaste. This enables libomptarget for Darwin, FreeBSD and NetBSD, NFCI otherwise. While at it, extend test for FreeBSD and check for -lrt iff on Linux. https://reviews.llvm.org/D30087 Files: lib/Driver/Tools.cpp test/Driver/fopenmp.