BillyONeal closed this revision.
BillyONeal added a comment.
In https://reviews.llvm.org/D33340#764206, @EricWF wrote:
> Sorry for the delay reviewing such a simple change.
No problem! Their simplicity also means no likely merge conflicts :)
In https://reviews.llvm.org/D33340#764213, @EricWF
EricWF added a comment.
@BillyONeal Changes like this are good for post-commit review (ie just commit
it). Adding clearly correct assertions and test cases is never an objectionable
thing.
https://reviews.llvm.org/D33340
___
cfe-commits mailing
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Sorry for the delay reviewing such a simple change.
https://reviews.llvm.org/D33340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
BillyONeal created this revision.
In my perf overhaul for MSVC++'s basic_string I wrote the null at data[oldsize]
instead of data[newsize]; adding asserts to catch that bug.
https://reviews.llvm.org/D33340
Files:
test/std/strings/basic.string/string.modifiers/string_erase/iter.pass.cpp
