EricWF updated this revision to Diff 100567.
EricWF added a comment.
This patch was initially reverted due to a failing test it caused elsewhere;
which has been address in this version.
https://reviews.llvm.org/D33538
Files:
docs/Modules.rst
lib/Basic/Module.cpp
EricWF added a comment.
Even after fixing the libc++ guards, the header still emits a #warning when
it's processed when coroutines are unavailable.
It seems like a useful feature test to have available. I'll commit shortly.
https://reviews.llvm.org/D33538
EricWF added a comment.
In https://reviews.llvm.org/D33538#765225, @rsmith wrote:
> In https://reviews.llvm.org/D33538#765146, @EricWF wrote:
>
> > In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> >
> > > Do we need to conditionalize this part of libc++? Nothing in the
> > > header
rsmith added a comment.
In https://reviews.llvm.org/D33538#765146, @EricWF wrote:
> In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
>
> > Do we need to conditionalize this part of libc++? Nothing in the
> > header appears to need compiler support.
>
>
> That's correct. I was mistaken
EricWF added a comment.
Also see r303936, which re-adds to the module map and
fixes the bug.
https://reviews.llvm.org/D33538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> Do we need to conditionalize this part of libc++? Nothing in the
> header appears to need compiler support.
That's correct. I was mistaken as to why this was needed. I mistook a bug in
libc++ for the reason
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33538#765062, @rsmith wrote:
> In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
>
> > Do we need to conditionalize this part of libc++? Nothing in the
>
rsmith added a comment.
In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> Do we need to conditionalize this part of libc++? Nothing in the
> header appears to need compiler support.
Oh wait, I see what's going on. You're not testing for whether coroutines is
enabled, you're
rsmith added a comment.
Do we need to conditionalize this part of libc++? Nothing in the
header appears to need compiler support.
https://reviews.llvm.org/D33538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added inline comments.
Comment at: test/Modules/requires-coroutines.mm:1
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -Wauto-import -fmodules-cache-path=%t -fmodules
-fimplicit-module-maps -F %S/Inputs %s -verify
Should this test be called
10 matches
Mail list logo
