This revision was automatically updated to reflect the committed changes.
Closed by commit rL310798: [AArch64] Add support for a MinGW AArch64 target
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D36364?vs=109935=110886#toc
Repository:
rL LLVM
compnerd accepted this revision.
compnerd added a comment.
Yeah, I think that this is okay.
https://reviews.llvm.org/D36364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
@compnerd - are you ok with this one as well?
https://reviews.llvm.org/D36364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell accepted this revision.
martell added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mstorsjo updated this revision to Diff 109935.
mstorsjo added a comment.
Added a fixme comment about this being incorrect for WinCE.
https://reviews.llvm.org/D36364
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets/AArch64.cpp
lib/Basic/Targets/AArch64.h
mstorsjo added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:130
+ case llvm::Triple::arm:
+ case llvm::Triple::thumb:
CmdArgs.push_back("thumb2pe");
martell wrote:
> I believe this was left incase someone wanted to do windows ce in future.
martell added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:130
+ case llvm::Triple::arm:
+ case llvm::Triple::thumb:
CmdArgs.push_back("thumb2pe");
I believe this was left incase someone wanted to do windows ce in future.
Can you add a
martell added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:129
+ else if (TC.getArch() == llvm::Triple::aarch64)
+CmdArgs.push_back("arm64pe");
+ else
mstorsjo wrote:
> martell wrote:
> > I believe the reason I used thumb2pe for the arm
mstorsjo added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:129
+ else if (TC.getArch() == llvm::Triple::aarch64)
+CmdArgs.push_back("arm64pe");
+ else
martell wrote:
> I believe the reason I used thumb2pe for the arm triple is because MS
mstorsjo updated this revision to Diff 109916.
mstorsjo added a comment.
Updated to use a switch, added a mapping of a missed case of thumb while
reformatting the if to a switch.
https://reviews.llvm.org/D36364
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets/AArch64.cpp
martell added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:129
+ else if (TC.getArch() == llvm::Triple::aarch64)
+CmdArgs.push_back("arm64pe");
+ else
I believe the reason I used thumb2pe for the arm triple is because MS gave us a
watered
mstorsjo added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:122-131
if (TC.getArch() == llvm::Triple::x86)
CmdArgs.push_back("i386pe");
- if (TC.getArch() == llvm::Triple::x86_64)
+ else if (TC.getArch() == llvm::Triple::x86_64)
compnerd added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:122-131
if (TC.getArch() == llvm::Triple::x86)
CmdArgs.push_back("i386pe");
- if (TC.getArch() == llvm::Triple::x86_64)
+ else if (TC.getArch() == llvm::Triple::x86_64)
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.
The machine name `arm64pe` passed to the linker is completely made up; gnu
binutils doesn't (afaik) support this, so it only has to match what the
corresponding (not yet merged) lld linker
14 matches
Mail list logo
