[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

This revision was automatically updated to reflect the committed changes. Closed by commit rL320920: [Driver, CodeGen] pass through and apply -fassociative-math (authored by spatel, committed by ). Changed prior to commit: https://reviews.llvm.org/D39812?vs=122158=127245#toc Repository: rL

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping * 4. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping * 3. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping * 2. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. Ping. https://reviews.llvm.org/D39812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel updated this revision to Diff 122158. spatel added a comment. Updated again - the last upload was missing the driver's test file. https://reviews.llvm.org/D39812 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel updated this revision to Diff 122155. spatel added a comment. Patch updated: Match gcc's handling of -fassociative-math with -fno-signed-zeros and -fno-trapping-math. I've created a new codegen option (-mreassociate) that maps directly to LLVM's 'reassoc' flag, so we limit the

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. In https://reviews.llvm.org/D39812#919699, @wristow wrote: > Yes, I think we want to match that behavior. But by "light up" 'nsz' and the > no-trapping-math attribute, do you mean automatically turn them on when > '-fassociative-math' is specified? I'd think it should

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

wristow added a comment. In https://reviews.llvm.org/D39812#919687, @spatel wrote: > I just reviewed the gcc docs: > https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html > > "[-fassociative-math] requires that both -fno-signed-zeros and > -fno-trapping-math be in effect." > > If we want to

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel added a comment. I just reviewed the gcc docs: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html "[-fassociative-math] requires that both -fno-signed-zeros and -fno-trapping-math be in effect." If we want to match that behavior, I need to change this patch to light up 'nsz' and

[PATCH] D39812: [Driver, CodeGen] pass through and apply -fassociative-math

spatel created this revision. Herald added a subscriber: mcrosier. There are 2 parts to getting the -fassociative-math command-line flag translated to LLVM FMF: 1. In the driver/frontend, we accept the flag and its 'no' inverse and deal with the interactions with other flags like -ffast-math.