joerg added a comment.
Things are different for a libgcc-based toolchain and a compiler-rt based
toolchain.
Repository:
rL LLVM
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krytarowski added subscribers: joerg, krytarowski.
krytarowski added a comment.
Does it work for you for 32-bit? @joerg opposed adoption of 32-bit version as
it seemed to be unimplemented..
Repository:
rL LLVM
https://reviews.llvm.org/D41240
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330572: [Solaris] __float128 is supported on Solaris/x86
(authored by ro, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith added a comment.
@fedor.sergeev Can you review this for correctness? Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ro added a comment.
ping^3
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
ping^2
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
I believe there's nothing more left for me here. Is the patch ok now?
Thanks.
Rainer
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ro updated this revision to Diff 127348.
ro added a comment.
Enables test/CodeGenCXX/float128-declarations.cpp on Solaris/x86, too.
Repository:
rC Clang
https://reviews.llvm.org/D41240
Files:
lib/Basic/Targets/OSTargets.h
test/CodeGenCXX/float128-declarations.cpp
Index:
ro added a comment.
In https://reviews.llvm.org/D41240#955391, @rsmith wrote:
> Mechanically, the code change looks fine, but I can't comment on whether this
> is a correct change for Solaris, or whether the type provided by `__float128`
> would use the right floating-point representation. You
rsmith added a comment.
Mechanically, the code change looks fine, but I can't comment on whether this
is a correct change for Solaris, or whether the type provided by `__float128`
would use the right floating-point representation. You will also need to
provide a test for this change.
ro added a comment.
I forgot: this patch is on top of https://reviews.llvm.org/D35755.
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ro created this revision.
ro added a reviewer: rsmith.
Herald added a subscriber: fedor.sergeev.
When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I
ran
into a few instances of
In file included from
14 matches
Mail list logo
