[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In D43500#1546089 , @lebedev.ri wrote: > In D43500#1546077 , @jdemeule wrote: > > > In D43500#1244518 , @JonasToth > > wrote: > > > > > What is

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

lebedev.ri added a comment. In D43500#1546077 , @jdemeule wrote: > In D43500#1244518 , @JonasToth wrote: > > > What is the status here? Will you continue to work on this patch @jdemeule > > (which would be great!)

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In D43500#1244518 , @JonasToth wrote: > What is the status here? Will you continue to work on this patch @jdemeule > (which would be great!) ? Hi, now, this patch contains only tests which are already covered with lit tests.

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

chgans added a comment. Hi, Using llvm-8 (llvm ubuntu repo), clang-replacement has improved, but there still a case when a comma is left beyond: if there was only one member init. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43500/new/ https://reviews.llvm.org/D43500

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

JonasToth added a comment. What is the status here? Will you continue to work on this patch @jdemeule (which would be great!) ? https://reviews.llvm.org/D43500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

alexfh added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( jdemeule wrote: > alexfh wrote: > > I wonder whether it's better to use lit for the tests that

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( alexfh wrote: > I wonder whether it's better to use lit for the tests that require formatting >

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( I wonder

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule updated this revision to Diff 136389. jdemeule added a comment. Update after review. https://reviews.llvm.org/D43500 Files: unittests/clang-tidy/CMakeLists.txt unittests/clang-tidy/ClangTidyTest.h unittests/clang-tidy/ModernizerModuleTest.cpp Index:

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

aaron.ballman added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160 + CleannedReplacements = std::move(FormattedReplacements); + if (!CleannedReplacements) +llvm_unreachable("!CleannedReplacements"); +} else {

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160 + CleannedReplacements = std::move(FormattedReplacements); + if (!CleannedReplacements) +llvm_unreachable("!CleannedReplacements"); +} else {

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

aaron.ballman added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + // Options. + if (Options.FormatStyle) { Extraneous whitespace. Comment at: unittests/clang-tidy/ClangTidyTest.h:147 + if (Options.FormatStyle)

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule updated this revision to Diff 135895. jdemeule added a comment. As discuss, I have removed the modifications but keep the tests. To have tests with meaning, I have also add a way to format code on 'runCheckOnCode'. https://reviews.llvm.org/D43500 Files:

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

ioeric added a comment. In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote: > In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > > > Is there a way to make clang-apply-replacements smarter

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

alexfh added a reviewer: ioeric. alexfh added a comment. In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > It seems, when they are apply directly from clang-tidy, the RefactoringTool > > engine is smart enough to remove trailing tokens. However, when fixes are > > exported,

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

aaron.ballman added a comment. In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote: > In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > > > Is there a way to make clang-apply-replacements

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > Is there a way to make clang-apply-replacements smarter rather than forcing > > every check to jump through hoops? I'm worried

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

malcolm.parsons added a comment. In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > Is there a way to make clang-apply-replacements smarter rather than forcing > every check to jump through hoops? I'm worried that if we have to fix > individual checks we'll just run into the

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

aaron.ballman added a comment. > It seems, when they are apply directly from clang-tidy, the RefactoringTool > engine is smart enough to remove trailing tokens. However, when fixes are > exported, clang-apply-replacements cannot do the same trick and will lead > trailing commas and colon Is