[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-20 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo abandoned this revision. mstorsjo added a comment. Fixed the issue via https://reviews.llvm.org/D44592 instead, thanks @efriedma for the pointers! Repository: rC Clang https://reviews.llvm.org/D44582 ___ cfe-commits mailing list

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-16 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D44582#1040643, @efriedma wrote: > The backend has code to generate SRet returns, which is used when > TargetLowering::CanLowerReturn returns false. Probably a tiny change to > X86CallingConv.td to use that codepath on Windows. Thanks, I

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. The backend has code to generate SRet returns, which is used when TargetLowering::CanLowerReturn returns false. Probably a tiny change to X86CallingConv.td to use that codepath on Windows. Repository: rC Clang https://reviews.llvm.org/D44582

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-16 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D44582#1040578, @efriedma wrote: > Can we just fix the bug in the backend, rather than trying to hack around it > in clang? That'd obviously be ideal - but I don't know how easy that'd be (not familiar enough with that aspect of LLVM); if

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-16 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Can we just fix the bug in the backend, rather than trying to hack around it in clang? Repository: rC Clang https://reviews.llvm.org/D44582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

2018-03-16 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd. On x86_64 mingw, long doubles are passed as arguments and returned as if they were a struct. For normal functions, this calling convention detail is handled within clang when generating the IR. When a math function is