GorNishanov closed this revision.
GorNishanov added a comment.
Committed as:
https://reviews.llvm.org/rCXX329237
and a flurry of cleanup fixes:
https://reviews.llvm.org/rCXX329239
https://reviews.llvm.org/rCXX329240
https://reviews.llvm.org/rCXX329245
https://reviews.llvm.org/D45121
EricWF accepted this revision.
EricWF added a comment.
Yeah, LGTM.
https://reviews.llvm.org/D45121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov updated this revision to Diff 141010.
GorNishanov added a comment.
- s/_LIBCPP_ALWAYS_INLINE/_LIBCPP_INLINE_VISIBILITY throughout
- Added _LIBCPP_INLINE_VISIBILITY to noop_coroutine constructor
@EricWF , good to go?
https://reviews.llvm.org/D45121
Files:
EricWF added inline comments.
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
GorNishanov wrote:
> EricWF wrote:
> > GorNishanov wrote:
> > > lewissbaker wrote:
> > > > EricWF
GorNishanov marked an inline comment as done.
GorNishanov added inline comments.
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
EricWF wrote:
> GorNishanov wrote:
> > lewissbaker
CaseyCarter accepted this revision.
CaseyCarter added inline comments.
Comment at: include/experimental/coroutine:288
+
+coroutine_handle() {
+ this->__handle_ = __builtin_coro_noop();
EricWF wrote:
> GorNishanov wrote:
> > CaseyCarter wrote:
> > >
EricWF added inline comments.
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
GorNishanov wrote:
> lewissbaker wrote:
> > EricWF wrote:
> > > This should just be
GorNishanov marked 11 inline comments as done.
GorNishanov added inline comments.
Comment at: include/experimental/coroutine:275
+return *reinterpret_cast<_Promise*>(
+__builtin_coro_promise(this->__handle_, __alignof(_Promise),
false));
+}
GorNishanov updated this revision to Diff 140983.
GorNishanov marked 2 inline comments as done.
GorNishanov added a comment.
- static_cast instead of reintrepret_cast in promise()
- 2 spaces indent in added code (the rest of the file stayed as is)
- added static_assert to check for done-ness and
CaseyCarter added a subscriber: STL_MSFT.
CaseyCarter added inline comments.
Comment at: include/experimental/coroutine:268
+: public coroutine_handle<> {
+ using _Base = coroutine_handle<>;
+ using _Promise = noop_coroutine_promise;
This file can't seem
GorNishanov marked 2 inline comments as done.
GorNishanov added inline comments.
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
lewissbaker wrote:
> EricWF wrote:
> > This should
EricWF added inline comments.
Comment at: include/experimental/coroutine:288
+
+coroutine_handle() {
+ this->__handle_ = __builtin_coro_noop();
Can `__builtin_coro_noop` produce a constant expression?
https://reviews.llvm.org/D45121
lewissbaker added inline comments.
Comment at: include/experimental/coroutine:294
+
+inline _LIBCPP_ALWAYS_INLINE
+noop_coroutine_handle noop_coroutine() _NOEXCEPT {
EricWF wrote:
> This should just be `_LIBCPP_INLINE_VISIBILITY`. We try not to use
>
GorNishanov updated this revision to Diff 140903.
GorNishanov added a comment.
incorporated review feedback
https://reviews.llvm.org/D45121
Files:
include/experimental/coroutine
GorNishanov added a comment.
In https://reviews.llvm.org/D45121#1056408, @lewissbaker wrote:
> The `coroutine_handle` type does not have a
> `from_address()` or a `from_promise()` static functions in the same way that
> the `coroutine_handle` implementation does.
> Is this intentional or an
EricWF added inline comments.
Comment at: include/experimental/coroutine:262
+struct noop_coroutine_promise {};
+
This whole thing should be wrapped in a `__has_builtin(__builtin_coro_noop)` so
the header still compiles with older clang versions.
lewissbaker accepted this revision.
lewissbaker added a comment.
This revision is now accepted and ready to land.
The `coroutine_handle` type does not have a
`from_address()` or a `from_promise()` static functions in the same way that
the `coroutine_handle` implementation does.
Is this
GorNishanov added a comment.
@EricWF , gentle ping. Super tini-tiny change. Last piece missing to be
post-Jax 2018 compilant
https://reviews.llvm.org/D45121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
GorNishanov created this revision.
GorNishanov added reviewers: EricWF, lewissbaker, modocache.
GorNishanov added dependencies: D45114: [coroutines] Add support for
llvm.coro.noop intrinsics, D45120: [coroutines] Add __builtin_coro_noop =>
llvm.coro.noop.
A recent addition to Coroutines TS
19 matches
Mail list logo
