chandlerc added a comment.
In https://reviews.llvm.org/D45505#1074747, @mstorsjo wrote:
> In https://reviews.llvm.org/D45505#1074744, @chandlerc wrote:
>
> > Definitely need tests here.
>
>
> Do you have any suggestion on where to create them and what kind? Just a
> normal test with a fake
mstorsjo added a comment.
In https://reviews.llvm.org/D45505#1074744, @chandlerc wrote:
> Definitely need tests here.
Do you have any suggestion on where to create them and what kind? Just a normal
test with a fake directory tree, or some sort of unit test for the gcc version
number matching
chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
Definitely need tests here.
But no concern w/ the idea of this.
Repository:
rC Clang
https://reviews.llvm.org/D45505
___
martell accepted this revision.
martell added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D45505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mstorsjo created this revision.
mstorsjo added reviewers: chandlerc, martell, ismail, rnk, compnerd, mati865,
yaron.keren.
Previously it would only accept a string as a GCC version if it had either two
components and no suffix, or three components with an optional suffix.
Debian and ubuntu
