[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

This revision was automatically updated to reflect the committed changes. Closed by commit rC336355: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates (authored by GBuella, committed by ). Repository: rC Clang https://reviews.llvm.org/D48715 Files: lib/CodeGen/CGBuiltin.cpp

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D48715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella added a comment. ping @spatel https://reviews.llvm.org/D48715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella updated this revision to Diff 154216. GBuella added a comment. As suggested, I added test cases with all predicates (in r336346). https://reviews.llvm.org/D48715 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx512f-builtins.c

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true spatel wrote: > GBuella wrote: > > spatel wrote: > > > Why are we deleting tests instead

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

spatel added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true GBuella wrote: > spatel wrote: > > Why are we deleting tests instead of replacing the

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true spatel wrote: > Why are we deleting tests instead of replacing the CHECK lines with the

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

spatel added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true Why are we deleting tests instead of replacing the CHECK lines with the new output?

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella created this revision. GBuella added reviewers: craig.topper, uriel.k, RKSimon, andrew.w.kaylor, spatel, scanon, efriedma. Herald added a subscriber: cfe-commits. This patch removes on optimization used with the TRUE/FALSE predicates, as was suggested in https://reviews.llvm.org/D45616